-
Notifications
You must be signed in to change notification settings - Fork 50
feat: job arrays #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: job arrays #174
Changes from 73 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
3abb561
feat: job arrays
johanneskoester 5e8acca
Update snakemake_executor_plugin_slurm/__init__.py
johanneskoester f9cb5ad
Merge branch 'main' into feat/jobarrays
cmeesters 6e3742c
Merge branch 'main' into feat/jobarrays
cmeesters 72b12ad
Merge branch 'main' into feat/jobarrays
cmeesters cce6fac
Merge branch 'main' into feat/jobarrays
cmeesters dbc04de
fix: merge conflict
cmeesters 8c580ec
feat: basic job wait implementation for arrays
cmeesters 720147d
fix: formatting
cmeesters af558f7
feat: updated testing code
cmeesters 1504763
fix: typo
cmeesters be01b04
fix: typo
cmeesters 80e587c
fix: consider 'all' case - then all jobs are considered array jobs, i…
cmeesters cc6a84d
fix: async execution added.
cmeesters 5d8cf01
refactor: submit_string woring for both arrays and ordinary jobs
cmeesters 1358be1
feat: added two helper functions: pending_jobs_for_rule and get_job_w…
cmeesters 6120c1b
feat: started implementation of array job submission
cmeesters 8152280
feat: avoiding array limit by raising WorkflowError 'not implemented'
cmeesters 25cd8d0
one step further in implementing arrays
cmeesters f97d708
fix: formatting
cmeesters 97831ca
fix: jobid handling for array jobs
cmeesters 83a1ba0
fix: submitting without stalling - not yet working. There is a block …
cmeesters ef477d0
proposed fix for https://github.com/snakemake/snakemake-executor-plug…
0cf6eed
fix: deadlock issue
cmeesters 8d033ce
Merge branch 'main' of github.com:snakemake/snakemake-executor-plugin…
cmeesters ed1e50d
Merge branch 'main' of github.com:snakemake/snakemake-executor-plugin…
cmeesters 009c164
fix: group job handling before array job handling to avoid api issue
cmeesters 57485b8
docs: added array documentation
cmeesters c8fa068
docs: documented the slurm-arra-limit flag
cmeesters 842753e
Fix small errors in further.md
fbartusch 081ecca
test: added array testcases
cmeesters ee39c7c
Merge branch 'feat/jobarrays' of github.com:snakemake/snakemake-execu…
cmeesters bb91765
fix: merge conflict
cmeesters c5a92f8
Merge branch 'feat/jobarrays' of github.com:snakemake/snakemake-execu…
cmeesters 6c1cbc3
fix: formatting
cmeesters eba3612
Merge branch 'feat/jobarrays' of github.com:snakemake/snakemake-execu…
cmeesters 2b2ae25
fix: formatting
cmeesters c5d22e3
fix: typo
cmeesters ef6da07
fix: syntax (critical)
cmeesters 938c1f2
Fix syntax. Add black format changes.
fbartusch 3f7549a
fix: formatting
cmeesters a099a23
Merge branch 'feat/jobarrays' of github.com:snakemake/snakemake-execu…
cmeesters a80e0ed
feat: setting max array size by cluster limit - taking minimum of arr…
cmeesters 6831182
refactor: get_max_array_size function due to stupid copilot overwrite
cmeesters 78eaf2b
feat: added array limit validation
cmeesters c766ca5
refactor: array limit validation
cmeesters 3eed042
refactor: logfile type conversion
cmeesters 94e7a0e
fix: gnarf - wrote shutils.split - is shlex!
cmeesters e3e6ff9
fix: missing f-string for exec_job in shell handshake
cmeesters 83f65ba
fix: better error message for failed array job submission
cmeesters 74d79be
fix: tests for array jobs, deleted one useless tests (sbatch failures)
cmeesters 329948b
fix: node exclusion is optional
cmeesters 78ba68f
fix: deleted accidentially added backup file
cmeesters dad46b5
fix: node exclusion is optional
cmeesters ff3f39a
fix: more stable status checks, if CI file system issue
cmeesters 9e1ec44
fix: better prefix for slurm logfiles for array jobs
cmeesters b2306d4
fix: deleted pending_jobs_for_rule - not used
cmeesters b90d19b
fix: formatting
cmeesters b5e9226
fix: removed unused import
cmeesters 38a7ab5
fix: removed unused import
cmeesters 03c91f1
fix: formatting
cmeesters 18dc93f
fix: max array size is max array size -1 under SLURM
cmeesters 1001ee7
fix: submission in chuncks working again - not blocking - encoding to…
cmeesters 07a0cc6
fix: now accounting for lost tick mark
cmeesters ed03477
fix: restored behaviour for first job (not in array execs), now consi…
cmeesters f340640
tests: new snakefile for array job tests
cmeesters b1603fc
tests: new test cases for array jobs
cmeesters 3471cfa
fix: restored previous function
cmeesters 2c7244f
fix: formatting
cmeesters b2bd750
fix: formatting
cmeesters d4da0b1
fix: trailing whitespace
cmeesters da0536c
Merge branch 'main' into feat/jobarrays
cmeesters ae8e765
Fix: catch type error
fbartusch f8dce8e
feat: updated jobstep requirement (just merged on bioconda)
cmeesters be64f6d
fix: update snakemake dependency
cmeesters da28f81
fix: introducing a storage class to ensure the presence of a test sui…
cmeesters c94716e
Merge branch 'main' into feat/jobarrays
cmeesters 9dcf4cc
fix: apparently the fixed stage-in of local test cases shadowed the o…
cmeesters 2b1edf9
Merge branch 'feat/jobarrays' of github.com:snakemake/snakemake-execu…
cmeesters 0569e7b
fix: adding a default method to get config settings (returns None)
cmeesters 900ab1a
fix: the executor stalled after a local rule, because the previous im…
cmeesters 494cd16
fix: changed two logger settings to debug in the array submission cod…
cmeesters bc47aa3
fix: one more status query timing message from info to debug
cmeesters 94805ec
feat: stabilizing array submission with adding a memory fudge factor …
cmeesters 36d680e
feat: version bump: jobstep plugin 0.6 is required - better memory ha…
cmeesters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.