Update progress indicators after finishing walking and learning#159
Open
kimsey0 wants to merge 1 commit intosnap-stanford:masterfrom
Open
Update progress indicators after finishing walking and learning#159kimsey0 wants to merge 1 commit intosnap-stanford:masterfrom
kimsey0 wants to merge 1 commit intosnap-stanford:masterfrom
Conversation
Author
|
@roks: Does this look OK? |
Author
|
@roks: Would you like to merge this? If not, I'll delete it. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the progress indicators end at 99.XX%, which looks like the walking and learning never finished.
I have matched the formatting of the progress prints in each of the two files, which is the reason for the different whitespace around
Verboseand the extra space at the end of the format string inword2vec.cpp.