Get Neighbors implementation for Undirected and Directed Graphs with Tests#164
Open
rohanbadlani wants to merge 4 commits intosnap-stanford:masterfrom
Open
Get Neighbors implementation for Undirected and Directed Graphs with Tests#164rohanbadlani wants to merge 4 commits intosnap-stanford:masterfrom
rohanbadlani wants to merge 4 commits intosnap-stanford:masterfrom
Conversation
Author
|
Adding in the implementation for directed graphs as well. |
Author
|
Added Tests in the tests/tests-TUNGraph.cpp and tests/tests-TNGraph.cpp that follow the same convention as all the other tests. These test basic functionality using a small test graph. SUNet Id: rbadlani |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throughout the usage of SNAP platform, there are many graph algorithms for which the user might need neighborhood data and hence adding that functionality as easy to use methods.
[Build] The build is passing.
[Testing] Tested the functionality and provides results as expected but will be writing rigorous tests.
I am not sure on where to add the documentation for this, but I have used comments in the codebase to make things quite clear and will be happy to help provide/edit documentation for this.
SUNet Id: rbadlani.