-
Notifications
You must be signed in to change notification settings - Fork 3
Add armhf cross-compilation support via candidate-armhf branch #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lengau
merged 13 commits into
candidate-armhf
from
copilot/fix-29598503-600908950-27c070ae-41cf-49b6-a772-dcc7c48042d6
Dec 6, 2025
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1fa7874
Initial plan
Copilot 85345d7
Configure armhf cross-compilation for ruff snap
Copilot 4fd5576
Address code review feedback for armhf configuration
Copilot cf7f88d
Fix build failure: correct architecture variable and binary installat…
Copilot 51601f1
Use target architecture for package-repositories as per uv-snap
Copilot 3fa051d
Add CI workflows for candidate-armhf branch
Copilot 3883148
Add PR trigger for candidate-armhf to release-to-candidate workflow
Copilot 25055f2
Revert PR trigger for candidate-armhf from release-to-candidate workflow
Copilot 5d840f5
Add test step to PR workflows
Copilot d9b10fb
Build only on arm64 for armhf branch PR workflow
Copilot 7b422ba
Merge pull-request and pull-request-armhf workflows
Copilot becb75d
Add PR number and GitHub token to test workflow
Copilot 0079328
Remove test step from PR workflow due to cross-compilation
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| name: Release (armhf) | ||
|
|
||
| on: | ||
| # Run the workflow each time new commits are pushed to the candidate-armhf branch. | ||
| push: | ||
| branches: [ "candidate-armhf" ] | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
| issues: write | ||
|
|
||
| jobs: | ||
| release: | ||
| name: 🚢 Release armhf to latest/candidate | ||
| runs-on: ubuntu-latest | ||
| environment: "Candidate Branch" | ||
| steps: | ||
| - name: 🚢 Release to latest/candidate | ||
| uses: snapcrafters/ci/release-to-candidate@main | ||
| with: | ||
| architecture: armhf | ||
| launchpad-token: ${{ secrets.LP_BUILD_SECRET }} | ||
| repo-token: ${{ secrets.SNAPCRAFTERS_BOT_COMMIT }} | ||
| store-token: ${{ secrets.SNAP_STORE_CANDIDATE }} | ||
|
|
||
| call-for-testing: | ||
| name: 📣 Create call for testing | ||
| needs: release | ||
| environment: "Candidate Branch" | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| issue-number: ${{ steps.issue.outputs.issue-number }} | ||
| steps: | ||
| - name: 📣 Create call for testing | ||
| id: issue | ||
| uses: snapcrafters/ci/call-for-testing@main | ||
| with: | ||
| architectures: armhf | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| test: | ||
| name: 🗒️ Test snap on armhf | ||
| needs: call-for-testing | ||
| runs-on: ubuntu-24.04-arm | ||
| steps: | ||
| - name: 🗒️ Run tests | ||
| uses: snapcrafters/ci/run-tests@main | ||
| with: | ||
| issue-number: ${{ needs.call-for-testing.outputs.issue-number }} | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| test-script: ./test.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Sync to armhf branch | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - candidate | ||
| workflow_dispatch: | ||
| workflow_call: | ||
|
|
||
| permissions: | ||
| issues: write | ||
| contents: write | ||
|
|
||
| jobs: | ||
| sync-armhf: | ||
| name: 🔄 Sync candidate branch to candidate-armhf | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout the source | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| token: ${{ secrets.SNAPCRAFTERS_BOT_COMMIT }} | ||
| fetch-depth: 0 | ||
| ref: candidate-armhf | ||
| - name: Merge from candidate | ||
| run: | | ||
| git pull | ||
| git config --global user.name "Snapcrafters Bot" | ||
| git config --global user.email "bot@snapcrafters.org" | ||
|
|
||
| git merge origin/candidate -m 'chore: merge candidate to candidate-armhf' | ||
| git push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot this won't work because it's cross-compiling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0079328. Removed the test step from the PR workflow since cross-compiled armhf binaries cannot run on the arm64 build runner. The workflow now only builds the snap to validate compilation. Testing will occur in the release workflow where the snap can be tested on actual armhf hardware.