perf: graceful shutdown of infinite loop #1028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements graceful shutdown functionality for the application by adding signal handlers for SIGINT and SIGTERM that properly close the Express server and database connections before terminating the process.
Key changes:
- Added graceful shutdown handlers for SIGINT and SIGTERM signals
- Implemented database connection pool cleanup functionality
- Refactored server initialization to capture server instance for controlled shutdown
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/index.ts | Added graceful shutdown function and signal handlers to properly close server and database connections |
| src/helpers/mysql.ts | Implemented closeDatabase function to properly close MySQL connection pools |
chore: lint fix
wa0x6e
force-pushed
the
perf-graceful-shutdown-of-infinite-loop
branch
from
eacb5ec to
b8b5a26
Compare
|
Will reopen if we notice some stray processes again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #1027
This PR also gracefully shutdown the infinite loop on process kill.
A little refactoring has been added to avoid code duplication, and centralize loop and shutdown management in 2 new helpers