feat: return and sort leaderboard by vp_value #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds VP (voting power) value functionality to the leaderboard system, allowing users to view and sort leaderboard entries by their voting power value.
- Adds
vp_valuefield to Vote andvpValuefield to Leaderboard GraphQL types - Includes
vp_valueas a sortable field in leaderboard operations - Updates SQL query to select and return the vp_value column
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/graphql/schema.gql | Adds vp_value field to Vote type and vpValue field to Leaderboard type, removes trailing commas from ProposalWhere input |
| src/graphql/operations/leaderboards.ts | Adds vp_value to ORDER_FIELDS array and includes it in the SQL SELECT query |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/625
Depends on snapshot-labs/snapshot-sequencer#571
This PR will: