Skip to content

fix: add pagination to loadSpaces #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025
Merged

fix: add pagination to loadSpaces #1042

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6e26fc
fix: add pagination to loadSpaces
ChaituVR Aug 13, 2025
9314a37
run map at the end
ChaituVR Aug 13, 2025
379ac4f
fix empty line
ChaituVR Aug 13, 2025
a4694a9
remove try catch like before
ChaituVR Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 32 additions & 9 deletions src/helpers/spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import log from './log';
import db from './mysql';

const RUN_INTERVAL = 120e3;
const BATCH_SIZE = 70000;
const TEST_STRATEGIES = [
'ticket',
'api',
Expand Down Expand Up @@ -160,17 +161,37 @@ function mapSpaces(spaces: Record<string, any>) {

async function loadSpaces() {
const startTime = +Date.now();
let offset = 0;
let allResults: any[] = [];
let hasMore = true;
let batchCount = 0;

while (hasMore) {
const query = `
SELECT id, settings, flagged, verified, turbo, turbo_expiration, hibernated, follower_count, proposal_count, vote_count
FROM spaces
WHERE deleted = 0
ORDER BY id ASC
LIMIT ?, ?
`;

const results = await db.queryAsync(query, [offset, BATCH_SIZE]);
batchCount++;

allResults = allResults.concat(results);
offset += BATCH_SIZE;

log.info(
`[spaces] loaded batch ${batchCount}: ${results.length} spaces (total: ${allResults.length})`
);

const query = `
SELECT id, settings, flagged, verified, turbo, turbo_expiration, hibernated, follower_count, proposal_count, vote_count
FROM spaces
WHERE deleted = 0
ORDER BY id ASC
`;
const results = await db.queryAsync(query);
if (results.length < BATCH_SIZE) {
hasMore = false;
}
}

const spaces = Object.fromEntries(
results.map(space => [
allResults.map(space => [
space.id,
{
...JSON.parse(space.settings),
Expand All @@ -188,7 +209,9 @@ async function loadSpaces() {
);

log.info(
`[spaces] total spaces ${Object.keys(spaces).length}, in (${(
`[spaces] total spaces ${
Object.keys(spaces).length
}, in ${batchCount} batches (${(
(+Date.now() - startTime) /
1000
).toFixed()}s)`
Expand Down