Skip to content

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 18, 2023

Toward https://github.com/snapshot-labs/workflow/issues/544

🧿 Current issues / What's wrong ?

The skin query on the hub is using data from space's cache.
This create refresh lag, and dependency on the space cache object.

💊 Fixes / Solution

Use a SQL query to get skins data from the database

🚧 Changes

  • Get skins data from the database

🛠️ Tests

  • Query some skin data from graphql => it should return same results as before

@wa0x6e wa0x6e requested a review from ChaituVR October 18, 2023 06:39
@wa0x6e wa0x6e added this to the Remove space cache milestone Oct 19, 2023
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Nov 6, 2023

Query is taking between 300 and 350ms to execute on main net database.

This is reasonable, considering a simple SELECT id FROM spaces WHERE id = ? is taking between 250 and 300ms.

@wa0x6e wa0x6e added the enhancement New feature or request label Jan 15, 2024
@wa0x6e wa0x6e closed this Dec 10, 2024
@wa0x6e wa0x6e reopened this Apr 29, 2025
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Apr 29, 2025

@ChaituVR reopening this one, as it's now relevant again in our quest of removing the big global spaces object

@wa0x6e wa0x6e closed this Apr 29, 2025
@wa0x6e wa0x6e reopened this Apr 29, 2025
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Apr 29, 2025

Furthermore, this query is now rarely used, since only used on v1, v2 has a different skin system

@ChaituVR ChaituVR removed their request for review July 13, 2025 03:01
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Aug 29, 2025

skins is now dead, as it's only used on v1, which does not support whitelabel anymore.

@wa0x6e wa0x6e closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant