improve membersURI

src/eip4824.ts

@@ -1,5 +1,5 @@
 import express from 'express';
-import { getSpace } from './helpers/spaces';
+import { getSpace, getUniqueVotersForSpace } from './helpers/spaces';
 import db, { sequencerDB } from './helpers/mysql';
 
 const router = express.Router();
@@ -35,28 +35,54 @@ router.get('/:space', async (req, res) => {
 
 router.get('/:space/members', async (req, res) => {
   let space: any = {};
+  let uniqueVotersResult: any = {};
 
   try {
-    space = await getSpace(req.params.space);
+    const spaceId = req.params.space;
+    const cursor = req.query.cursor || null;
+    // Default pageSize is set to 100, this is the query limit.
 
+    space = await getSpace(spaceId);
     if (!space.verified) return res.status(400).json({ error: 'INVALID' });
+
+    uniqueVotersResult = await getUniqueVotersForSpace(spaceId, cursor);
   } catch (e) {
     return res.status(404).json({ error: 'NOT_FOUND' });
   }
 
-  const members = [...space.admins, ...space.moderators, ...space.members].map(
-    member => ({
-      type: 'EthereumAddress',
-      id: member
-    })
-  );
-
-  return res.json({
+  // Combine all members and map them to JSON strings for uniqueness check
+  const allMembersJSON = [
+    ...space.admins.map(admin =>
+      JSON.stringify({ type: 'EthereumAddress', id: admin })
+    ),
+    ...space.moderators.map(moderator =>
+      JSON.stringify({ type: 'EthereumAddress', id: moderator })
+    ),
+    ...space.members.map(member =>
+      JSON.stringify({ type: 'EthereumAddress', id: member })
+    ),
+    ...uniqueVotersResult.voters.map(voter =>
+      JSON.stringify({ type: 'EthereumAddress', id: voter })
+    )
+  ];
+
+  // Convert the array of JSON strings to a Set to remove duplicates, then back to an array
+  const uniqueMembersJSON = [...new Set(allMembersJSON)];
+
+  // Convert each JSON string back to an object
+  const members = uniqueMembersJSON.map(memberJSON => JSON.parse(memberJSON));
+
+  const responseObject = {
     '@context': context,
     type: 'DAO',
     name: space.name,
-    members
-  });
+    members: members,
+    nextCursor: uniqueVotersResult.nextCursor
+      ? uniqueVotersResult.nextCursor
+      : undefined
+  };
+
+  return res.json(responseObject);
 });
 
 router.get('/:space/proposals', async (req, res) => {

src/helpers/spaces.ts

@@ -145,6 +145,50 @@ async function getVotes() {
   return await db.queryAsync(query);
 }
 
+export async function getUniqueVotersForSpace(
+  spaceId,
+  cursor = null,
+  pageSize = 100
+) {
+  let query, params;
+
+  // Adjust the query based on whether a cursor is provided
+  if (cursor) {
+    // Query to use when there is a cursor value, fetching results after the cursor
+    query = `
+      SELECT DISTINCT voter
+      FROM votes
+      WHERE space = ? AND voter > ?
+      ORDER BY voter
+      LIMIT ?
+    `;
+    params = [spaceId, cursor, pageSize];
+  } else {
+    // Query to use for the first page, without a cursor
+    query = `
+      SELECT DISTINCT voter
+      FROM votes
+      WHERE space = ?
+      ORDER BY voter
+      LIMIT ?
+    `;
+    params = [spaceId, pageSize];
+  }
+
+  const results = await db.queryAsync(query, params);
+
+  if (!results || results.length === 0)
+    return Promise.reject(new Error('NOT_FOUND'));
+
+  // As the results are ordered, the last voter ID can serve as the next cursor,
+  const nextCursor =
+    results.length === pageSize ? results[results.length - 1].voter : null;
+  return {
+    voters: results.map(row => row.voter),
+    nextCursor: nextCursor
+  };
+}
+
 async function getFollowers() {
   const query = `
     SELECT space, COUNT(id) as count,