refactor: use default argument

Author: wa0x6e

src/helpers/spaceValidation.ts

@@ -6,7 +6,7 @@ const DEFAULT_SNAPSHOT_ENV: string = 'testnet';
 
 export async function validateSpaceSettings(
   originalSpace: any,
-  snapshotEnv = DEFAULT_SNAPSHOT_ENV
+  snapshotEnv = process.env.NETWORK ?? DEFAULT_SNAPSHOT_ENV
 ): Promise<void> {
   const spaceType = originalSpace.turbo ? 'turbo' : 'default';
   const space = snapshot.utils.clone(originalSpace);

src/writer/proposal.ts

@@ -65,7 +65,7 @@ async function validateSpace(space: any) {
     return Promise.reject('space hibernated');
   }
 
-  await validateSpaceSettings(space, process.env.NETWORK);
+  await validateSpaceSettings(space);
 }
 
 export async function verify(body): Promise<any> {

src/writer/settings.ts

@@ -23,15 +23,12 @@ export async function verify(body): Promise<any> {
   const space = await getSpace(msg.space, true);
 
   try {
-    await validateSpaceSettings(
-      {
-        ...msg.payload,
-        id: msg.space,
-        deleted: space?.deleted,
-        turbo: space?.turbo
-      },
-      process.env.NETWORK
-    );
+    await validateSpaceSettings({
+      ...msg.payload,
+      id: msg.space,
+      deleted: space?.deleted,
+      turbo: space?.turbo
+    });
   } catch (e) {
     return Promise.reject(e);
   }

test/unit/writer/settings.test.ts

@@ -56,7 +56,8 @@ const LIMITS = {
 };
 const ECOSYSTEM_LIST = ['test.eth', 'snapshot.eth'];
 
-const mockGetSpaceType = jest.fn(async (space: any): Promise<string> => {
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const mockGetSpaceType = jest.fn(async (_space: any): Promise<string> => {
   return 'default';
 });
 jest.mock('../../../src/helpers/options', () => {
@@ -234,15 +235,12 @@ describe('writer/settings', () => {
       it('calls validateSpaceSettings with correct parameters', async () => {
         await verify(input);
 
-        expect(mockValidateSpaceSettings).toHaveBeenCalledWith(
-          {
-            ...JSON.parse(input.msg).payload,
-            id: JSON.parse(input.msg).space,
-            deleted: spacesGetSpaceFixtures.deleted,
-            turbo: spacesGetSpaceFixtures.turbo
-          },
-          'mainnet'
-        );
+        expect(mockValidateSpaceSettings).toHaveBeenCalledWith({
+          ...JSON.parse(input.msg).payload,
+          id: JSON.parse(input.msg).space,
+          deleted: spacesGetSpaceFixtures.deleted,
+          turbo: spacesGetSpaceFixtures.turbo
+        });
       });
 
       it('passes when validateSpaceSettings succeeds and strategy count is valid', async () => {