Skip to content

fix: enable alias voting and propose globally #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix: enable alias voting and propose globally #347

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
76668d7
fix: enable alias voting and propose globally
wa0x6e May 6, 2024
e98c544
Merge branch 'master' into feat-alias-vote-and-propose
wa0x6e May 7, 2024
e59cc9f
Merge branch 'master' into feat-alias-vote-and-propose
ChaituVR May 8, 2024
4f152ab
fix: remove unused aliasable actions
wa0x6e May 8, 2024
429b0d5
Merge branch 'feat-alias-vote-and-propose' of https://github.com/snap…
wa0x6e May 8, 2024
fdb0173
Merge branch 'master' into feat-alias-vote-and-propose
ChaituVR May 14, 2024
ed5f087
Merge branch 'master' into feat-alias-vote-and-propose
ChaituVR May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/ingestor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,32 +61,29 @@ export default async function ingestor(req) {
if (!Object.keys(hashTypes).includes(hash)) return Promise.reject('wrong types');
type = hashTypes[hash];

let aliased = false;
if (!['settings', 'alias', 'profile'].includes(type)) {
if (!message.space) return Promise.reject('unknown space');

const space = await getSpace(message.space, false, message.network);
if (!space) return Promise.reject('unknown space');
network = space.network;
if (space.voting?.aliased) aliased = true;
}

// Check if signing address is an alias
const aliasTypes = ['follow', 'unfollow', 'subscribe', 'unsubscribe', 'profile'];
const aliasOptionTypes = [
const aliasTypes = [
'follow',
'unfollow',
'subscribe',
'unsubscribe',
'profile',
'vote',
'vote-array',
'vote-string',
'proposal',
'delete-proposal',
'statement'
'update-proposal'
];
if (body.address !== message.from) {
if (!aliasTypes.includes(type) && !aliasOptionTypes.includes(type))
return Promise.reject('wrong from');

if (aliasOptionTypes.includes(type) && !aliased) return Promise.reject('alias not enabled');

if (!aliasTypes.includes(type)) return Promise.reject('wrong from');
if (!(await isValidAlias(message.from, body.address))) return Promise.reject('wrong alias');
}

Expand Down