feat: overriding strategies for non pro #581
Open
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR implements validation to restrict overriding strategies to pro (turbo) spaces only, addressing GitHub issue #631. The change ensures that non-pro spaces cannot use overriding strategies when saving space settings or creating proposals.
- Added validation logic to reject overriding strategies for non-turbo spaces
- Added comprehensive test coverage for both rejection and acceptance scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/helpers/validation.ts | Added validation check to reject overriding strategies for non-turbo spaces |
| test/unit/helpers/validation.test.ts | Added test cases to verify override strategy validation for both turbo and non-turbo spaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/631
This PR will reject space setting saving, as well as proposal creation, when a non pro space is using overriding strategies.
List of overriding strategies from https://score.snapshot.org/api/strategies