feat: add support for proposals with pending results #1055
Conversation
wa0x6e
force-pushed
the
show-pending-results-message
branch
from
0eca2bc to
cacab7b
Compare
wa0x6e
force-pushed
the
show-pending-results-message
branch
from
cacab7b to
816e89e
Compare
|
Any idea why these proposal are stuck with results not finalized? Is just proposal with invalid score? |
|
We should show the logo Shutter on proposals with Privacy |
|
Proposals are stuck for various reasons:
There's currently ~260 closed proposals with pending state. Will trigger the score finalization manually. We should have a somewhere to ensure the finalization is triggered in case webhook is lost |
There was a problem hiding this comment.
Looks good to me, how do we trigger webhook? I visited your proposal on v1 to see how it's handled there and it looks like it triggered decryption.
Do we trigger it from the UI? If that's the case then we probably should bring back that trigger to new UI, otherwise we won't trigger it 🤔
Computation is triggered via webhook, on proposal close, everything is done on backend, no more trigger for that from the UI. There's a few cases where finalization trigger are missed, as webhook are not retried on error, need to work on a solution to ensure all trigger is called. |
Originally `completed` was used only for onchain spaces and was used for execution, but later on it was reused for pending results (#1055). This meant that it started carrying two very different meanings and broke things, so later on completed for onchain spaces was updated to match offchain space meaning (#1075) which broke onchain execution.
Originally `completed` was used only for onchain spaces and was used for execution, but later on it was reused for pending results (#1055). This meant that it started carrying two very different meanings and broke things, so later on completed for onchain spaces was updated to match offchain space meaning (#1075) which broke onchain execution.
* fix: separate completed and execution_settled Originally `completed` was used only for onchain spaces and was used for execution, but later on it was reused for pending results (#1055). This meant that it started carrying two very different meanings and broke things, so later on completed for onchain spaces was updated to match offchain space meaning (#1075) which broke onchain execution. * chore: add execution_settled field This will replace completed in the future. Renaming fields in API are annoying because we need to carry two in the API during migration. For now we are just adding new field, but still using old one in UI. In the future next time we update API we can just remove completed field and start using execution_settled on UI.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/332
This PR adds support for offchain proposals with pending results (when
scores_stateis notfinal)Pending score happens for:
How to test
On proposal with privacy
On proposal without privacy
Note
We don't support when the proposal has
scores_stateasinvalidstate, since it's not handled on v1 either