Add invalid request handling callback for websocket server#444
Open
PragmaTwice wants to merge 1 commit intosnapview:masterfrom
Open
Add invalid request handling callback for websocket server#444PragmaTwice wants to merge 1 commit intosnapview:masterfrom
PragmaTwice wants to merge 1 commit intosnapview:masterfrom
Conversation
e6d8ea2 to
869d798
Compare
Member
|
An alternative solution would be returning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It closes #443.
This patch provides a method to solve this problem.
A new method
on_invalid_request()(with a default impl) is added intoCallback. (It doesn't break the current API and also keeps the current default behavior so that no users code will be broken.)By default the behavior has no change: the connection will just be dropped if the server get some invalid request (e.g. no connection upgrade header), but users can define their own
on_invalid_request()to return a valid response for it.It also makes the library more compliant to the standards, refer to RFC 6455:
A simple use case: