fix: make browser testing mandatory for Claude Code#62
Open
s62dads4-rgb wants to merge 1 commit intosnarktank:mainfrom
Open
fix: make browser testing mandatory for Claude Code#62s62dads4-rgb wants to merge 1 commit intosnarktank:mainfrom
s62dads4-rgb wants to merge 1 commit intosnarktank:mainfrom
Conversation
…rification CLAUDE.md had weak "if available" browser testing language while prompt.md (Amp) had mandatory language. This mismatch meant Claude Code iterations would skip browser verification entirely, defeating the purpose of the dev-browser skill for catching UI regressions like broken routes/404s. Changes: - CLAUDE.md: match prompt.md mandatory browser testing with dev-browser skill - Both files: add step to verify ALL pages/routes still work (no 404s) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Greptile OverviewGreptile SummaryThis PR strengthens browser testing requirements for frontend stories to prevent regressions from slipping through. The changes align Key improvements:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Agent as Ralph Agent (Claude Code/Amp)
participant FS as File System
participant Browser as dev-browser skill
participant UI as Application UI
Agent->>FS: Read prd.json
FS-->>Agent: Frontend story found (passes: false)
Agent->>FS: Implement UI changes
Agent->>Agent: Run quality checks (typecheck, lint)
alt Browser Testing (Required for Frontend Stories)
Agent->>Browser: Load dev-browser skill
Browser-->>Agent: Browser session started
Agent->>Browser: Navigate to changed page
Browser->>UI: Load page
UI-->>Browser: Page rendered
Browser-->>Agent: Screenshot + status
Agent->>Browser: Verify UI changes work
Browser-->>Agent: Changes verified ✓
Agent->>Browser: Navigate to ALL other pages/routes
loop Each Route
Browser->>UI: Load route
UI-->>Browser: Route rendered
Browser-->>Agent: Route status (200 or 404)
end
Agent->>Agent: Confirm no 404s, no broken navigation
Agent->>FS: Commit changes
Agent->>FS: Update prd.json (passes: true)
else Pre-PR Behavior (Optional Testing)
Agent->>FS: Log "manual verification needed"
Agent->>FS: Update prd.json (passes: true)
Note over Agent,UI: ❌ Regressions go undetected
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-browserskillWhat changed
CLAUDE.mddev-browserskillprompt.mdWhy this matters
The README already states browser verification is required, but CLAUDE.md contradicted it. Claude takes the path of least resistance — if the prompt says "if available... note manual verification needed", it will always skip browser testing. This led to regressions like broken routes/404s going undetected.
🤖 Generated with Claude Code