Skip to content

make protobug import relative?#203

Open
ZacharyACoon wants to merge 1 commit intomasterfrom
relative_protolib_import
Open

make protobug import relative?#203
ZacharyACoon wants to merge 1 commit intomasterfrom
relative_protolib_import

Conversation

@ZacharyACoon
Copy link
Contributor

Python implementation can't seem to build/import this correctly. Making it relative seems to fix it for me, but I'm not sure if this would interfere with your java implementation.

@ZacharyACoon ZacharyACoon requested a review from fireduck64 June 13, 2021 23:58
@fireduck64
Copy link
Member

ERROR: /home/nerd/snowblossom.git/protolib/BUILD:13:18: error executing shell command: '/bin/bash -c bazel-out/host/bin/external/com_google_protobuf/protoc --descriptor_set_out=bazel-out/k8-fastbuild/bin/protolib/protogrpc_pb/descriptor.source.bin --proto_path=bazel-out/k8-fastbuild/b...' failed (Exit 1): bash failed: error executing command /bin/bash -c ... (remaining 1 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox bash failed: error executing command /bin/bash -c ... (remaining 1 argument(s) skipped)

Use --sandbox_debug to see verbose messages from the sandbox
trie.proto: File not found.
protolib/snowblossom.proto: Import "trie.proto" was not found or had errors.
protolib/snowblossom.proto:295:12: "TrieNode" is not defined.
protolib/snowblossom.proto:299:12: "TrieNode" is not defined.
protolib/mining_pool.proto: Import "protolib/snowblossom.proto" was not found or had errors.
protolib/mining_pool.proto:22:3: "BlockHeader" is not defined.
protolib/mining_pool.proto:28:3: "BlockHeader" is not defined.
protolib/mining_pool.proto:13:50: "SubmitReply" is not defined.

Copy link
Member

@fireduck64 fireduck64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the java not compile, it really needs to compile with both. I imagine there is some solution but I don't know what it is.

@ZacharyACoon
Copy link
Contributor Author

In python, it seems to work if I cd into the protolib directory.
I'm going to see if I can mess with it to make my suggested change work with the java portion in docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants