Skip to content

SNOW-2184600: reduce binary size by opt-out arrow-go/compute package #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datdao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SNOW-2184600: reduce binary size by opt-out arrow-go/compute package #1459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions arrow_batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
//go:build !nobatch
// +build !nobatch

package gosnowflake

import (
"github.com/apache/arrow-go/v18/arrow"
)

func (arc *arrowResultChunk) decodeArrowBatch(scd *snowflakeChunkDownloader) (*[]arrow.Record, error) {
var records []arrow.Record
defer arc.reader.Release()

for arc.reader.Next() {
rawRecord := arc.reader.Record()

record, err := arrowToRecord(scd.ctx, rawRecord, arc.allocator, scd.RowSet.RowType, arc.loc)
if err != nil {
return nil, err
}
records = append(records, record)
}

return &records, arc.reader.Err()
}
18 changes: 0 additions & 18 deletions arrow_chunk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"encoding/base64"
"time"

"github.com/apache/arrow-go/v18/arrow"
"github.com/apache/arrow-go/v18/arrow/ipc"
"github.com/apache/arrow-go/v18/arrow/memory"
)
Expand Down Expand Up @@ -51,23 +50,6 @@ func (arc *arrowResultChunk) decodeArrowChunk(ctx context.Context, rowType []exe
return chunkRows, arc.reader.Err()
}

func (arc *arrowResultChunk) decodeArrowBatch(scd *snowflakeChunkDownloader) (*[]arrow.Record, error) {
var records []arrow.Record
defer arc.reader.Release()

for arc.reader.Next() {
rawRecord := arc.reader.Record()

record, err := arrowToRecord(scd.ctx, rawRecord, arc.allocator, scd.RowSet.RowType, arc.loc)
if err != nil {
return nil, err
}
records = append(records, record)
}

return &records, arc.reader.Err()
}

// Build arrow chunk based on RowSet of base64
func buildFirstArrowChunk(rowsetBase64 string, loc *time.Location, alloc memory.Allocator) (arrowResultChunk, error) {
rowSetBytes, err := base64.StdEncoding.DecodeString(rowsetBase64)
Expand Down
Loading