Skip to content

Conversation

@sfc-gh-ddas
Copy link
Contributor

@sfc-gh-ddas sfc-gh-ddas commented Dec 27, 2025

WIF autodetect feature was already removed from ODBC in accordance with this doc and WIF is still not supported in PDO. This PR removes support from this feature from LibSFC as it is no longer used.

@sfc-gh-ddas sfc-gh-ddas changed the title Snow 2251281/remove wif autodetect Remove wif autodetect Dec 29, 2025
@sfc-gh-ddas sfc-gh-ddas marked this pull request as ready for review December 29, 2025 09:12
@sfc-gh-ddas sfc-gh-ddas requested a review from a team as a code owner December 29, 2025 09:12
@sfc-gh-ddas sfc-gh-ddas changed the title Remove wif autodetect SNOW-2251281: Remove wif autodetect Dec 29, 2025
@sfc-gh-ddas sfc-gh-ddas changed the title SNOW-2251281: Remove wif autodetect SNOW-2251281 | SNOW-2251267: Remove wif autodetect Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2251281/remove-wif-autodetect branch 2 times, most recently from 8bc68a4 to 6aca3b6 Compare January 13, 2026 13:41
@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2251281/remove-wif-autodetect branch 2 times, most recently from 84e9d66 to 2100134 Compare January 19, 2026 13:46
@sfc-gh-ddas sfc-gh-ddas force-pushed the SNOW-2251281/remove-wif-autodetect branch from 2100134 to 0020aa2 Compare January 20, 2026 11:05
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.35%. Comparing base (cc79efd) to head (0020aa2).

Files with missing lines Patch % Lines
cpp/lib/Authenticator.cpp 0.00% 4 Missing ⚠️
lib/client.c 0.00% 3 Missing ⚠️
cpp/WifAttestation.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
+ Coverage   80.19%   80.35%   +0.15%     
==========================================
  Files         136      136              
  Lines       11929    11922       -7     
==========================================
+ Hits         9567     9580      +13     
+ Misses       2362     2342      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-ddas sfc-gh-ddas merged commit b6c8501 into master Jan 21, 2026
70 of 72 checks passed
@sfc-gh-ddas sfc-gh-ddas deleted the SNOW-2251281/remove-wif-autodetect branch January 21, 2026 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants