Jw/snow 1942875 init cicd templates #2135
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-jwilkowski
force-pushed
the
jw/SNOW-1942875-init-cicd-templates
branch
from
9df5bfd to
d4088d9
Compare
sfc-gh-jwilkowski
force-pushed
the
jw/SNOW-1942875-init-cicd-templates
branch
from
d4088d9 to
2dc6ebb
Compare
| @@ -0,0 +1,13 @@ | |||
| # Copyright (c) 2025 Snowflake Inc. | |||
There was a problem hiding this comment.
I'd put that module inside init plugin (../_plugins/init/cicd) - currently it is not used by any other context and is not providing new commands
| raise ClickException(f"Can not merge template with {type(other)}") | ||
|
|
||
| errors = [] | ||
| if self.minimum_cli_version != other.minimum_cli_version: |
There was a problem hiding this comment.
Why not just using max here?
| @@ -0,0 +1,24 @@ | |||
| # Copyright (c) 2024 Snowflake Inc. | |||
Comment on lines
+297
to
+307
| if _is_remote_source(template_source): | ||
| template_root = _fetch_remote_template( | ||
| url=template_source, path=template, destination=tmpdir # type: ignore | ||
| ) | ||
| else: | ||
| template_root = _fetch_local_template( | ||
| template_source=SecurePath(template_source), | ||
| path=template, | ||
| destination=tmpdir, | ||
| ) | ||
| return template_root |
There was a problem hiding this comment.
Suggested change
| if _is_remote_source(template_source): | |
| template_root = _fetch_remote_template( | |
| url=template_source, path=template, destination=tmpdir # type: ignore | |
| ) | |
| else: | |
| template_root = _fetch_local_template( | |
| template_source=SecurePath(template_source), | |
| path=template, | |
| destination=tmpdir, | |
| ) | |
| return template_root | |
| if _is_remote_source(template_source): | |
| return _fetch_remote_template( | |
| url=template_source, path=template, destination=tmpdir # type: ignore | |
| ) | |
| return _fetch_local_template( | |
| template_source=SecurePath(template_source), | |
| path=template, | |
| destination=tmpdir, | |
| ) |
| return MessageResult(f"Initialized the new project in {path}") | ||
|
|
||
|
|
||
| def clone( |
There was a problem hiding this comment.
"_fetch_cicd_template" would be a better name - "clone" assumes the template lives in remote repo
| CIProviderOption = typer.Option( | ||
| None, | ||
| "--ci-provider", | ||
| help=f"CI provider to generate workflow for.", |
There was a problem hiding this comment.
Suggested change
| help=f"CI provider to generate workflow for.", | |
| help=f"generate CI/CD workflow for given provider.", |
| template: Optional[str] = TemplateOption, | ||
| template_source: Optional[str] = SourceOption, | ||
| ci_provider: Optional[CIProviderChoices] = CIProviderOption, | ||
| ci_template_source: Optional[str] = CITemplateSourceOption, |
There was a problem hiding this comment.
Can we validate that "ci_provider" must be defined if "ci_template_source" is procided?
|
|
||
|
|
||
| def post_generate(template_root: SecurePath, ci_provider: Optional[CIProvider]): | ||
| CIProviderManager.project_post_gen_cleanup(ci_provider, template_root) |
There was a problem hiding this comment.
Why is this needed? What we assume about Ci/CD templates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...