Snow 2306184 ng config support 3

[sfc-gh-mraba]

Pre-review checklist

• I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
• I've added or updated automated unit tests to verify correctness of my new code.
• I've added or updated integration tests to verify correctness of my new code.
• I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
• I've confirmed that my changes are working by executing CLI's commands manually on Windows.
• I've confirmed that my changes are up-to-date with the target branch.
• I've described my changes in the release notes.
• I've described my changes in the section below.
• I've described my changes in the documentation.

Changes description

This PR refactors the Snowflake CLI configuration management by removing the module-level CONFIG_MANAGER singleton and replacing it with a factory-based approach managed through the CliGlobalContext. This change improves testability and eliminates test flakiness caused by shared global state.

[graphite-app]

The property _version_cache_file is now a method rather than a class variable, but it's still being evaluated immediately during initialization when assigned to self._cache_file. This defeats the purpose of lazy evaluation.

Consider modifying this approach to truly implement lazy loading:

def __init__(self):
    self._cache_file = None  # Initialize as None

@property
def _cache_file(self):
    if self.__cache_file is None:
        self.__cache_file = self._version_cache_file
    return self.__cache_file

@_cache_file.setter
def _cache_file(self, value):
    self.__cache_file = value

This way, the property is only evaluated when first accessed, not during initialization.

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

The class name was changed from TestProcessor to AcmeProcessor, but this comment still refers to TestProcessor. Please update the comment to refer to AcmeProcessor to maintain consistency with the renamed class.

Suggested change

	# TestProcessor is never invoked, otherwise calling its methods will make the test fail
	# AcmeProcessor is never invoked, otherwise calling its methods will make the test fail

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[sfc-gh-mraba]

The class was renamed to avoid warnings during tests collection.

[sfc-gh-jwilkowski]

I left 1 important question about connections_file_override which does not seem to be needed (maybe yet?). Otherwise a general comment would be about recurring issues across this PR:

• lots of local imports, where I don't think most of them would cause circular deps
• lots of comments that don't add much value
• I've seen this pattern repeating several times - maybe path resolver could go into SecurePath so that we can avoid repeating those?

# Resolve Windows short paths to prevent cleanup issues
resolved_tmp_dir = path_resolver(tmp_dir)
config_path = Path(resolved_tmp_dir) / "config.toml"

Otherwise, looks great!

[sfc-gh-jwilkowski]

nit: local import

[sfc-gh-jwilkowski]

?

path=self.connections_file_override or connections_file

[sfc-gh-jwilkowski]

actually is that override even needed? We don't seem to be using it anywhere?

[sfc-gh-mraba]

With connector based singleton this was created by default. As we are dropping the connector version of singleton we need to have our own support for connections.toml