Skip to content

Commit d158fd4

Browse files
SNOW-1473274 Sign assembly only when releasing (#974)
### Description SNOW-1473274 Sign assembly only when releasing ### Checklist - [x] Code compiles correctly - [x] Code is formatted according to [Coding Conventions](../blob/master/CodingConventions.md) - [x] Created tests which fail without the change (if possible) - [x] All tests passing (`dotnet test`) - [x] Extended the README / documentation, if necessary - [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
1 parent 39dcb03 commit d158fd4

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

Snowflake.Data.Tests/Snowflake.Data.Tests.csproj

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
1212
<LangVersion>9</LangVersion>
1313
<DefineConstants>$(SEQUENTIAL_ENV)</DefineConstants>
14-
<AssemblyOriginatorKeyFile>..\sign\publicKey.snk</AssemblyOriginatorKeyFile>
15-
<SignAssembly>true</SignAssembly>
16-
<DelaySign>true</DelaySign>
1714
</PropertyGroup>
1815
<ItemGroup>
1916
<PackageReference Include="JunitXml.TestLogger" Version="3.1.12" />
@@ -40,12 +37,6 @@
4037
<Reference Include="System.Net.Http.WebRequest" />
4138
</ItemGroup>
4239

43-
<ItemGroup>
44-
<None Include="..\sign\publicKey.snk">
45-
<Link>publicKey.snk</Link>
46-
</None>
47-
</ItemGroup>
48-
4940
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
5041
<DebugType>full</DebugType>
5142
<DebugSymbols>True</DebugSymbols>

Snowflake.Data/Snowflake.Data.csproj

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
<Version>3.1.0</Version>
1616
<DebugType>Full</DebugType>
1717
<LangVersion>7.3</LangVersion>
18+
</PropertyGroup>
19+
20+
<PropertyGroup Condition="'$(Configuration)' == 'Release'">
1821
<AssemblyOriginatorKeyFile>..\sign\publicKey.snk</AssemblyOriginatorKeyFile>
1922
<DelaySign>true</DelaySign>
2023
<SignAssembly>true</SignAssembly>
@@ -43,9 +46,9 @@
4346
</ItemGroup>
4447

4548
<ItemGroup Condition="'$(Configuration)' != 'Release'">
46-
<InternalsVisibleTo Include="Snowflake.Data.Tests,PublicKey=0024000004800000940000000602000000240000525341310004000001000100c159643cbf31e9bbbe7920091c39ecbd988b3e102df664830b33f12c9d838b07463682948cb56bbc414311fa019d6bca1dc08bc9d54684667fdd94ddf140f499ccb66795322128ba1804d8342fec912cea2704fe09c82dbf03bf10817330537d57e8177d92c205e93278245d18a84f185c53d1c5d917171c9807ac769ae9dfcb" />
49+
<InternalsVisibleTo Include="Snowflake.Data.Tests" />
4750
<!--needed by Moq to be able to mock internal interfaces-->
48-
<InternalsVisibleTo Include="DynamicProxyGenAssembly2,PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7" />
51+
<InternalsVisibleTo Include="DynamicProxyGenAssembly2" />
4952
</ItemGroup>
5053

5154
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
@@ -68,7 +71,7 @@
6871
<Folder Include="Properties\" />
6972
</ItemGroup>
7073

71-
<ItemGroup>
74+
<ItemGroup Condition="'$(Configuration)' == 'Release'">
7275
<None Include="..\sign\publicKey.snk">
7376
<Link>publicKey.snk</Link>
7477
</None>

0 commit comments

Comments
 (0)