Skip to content

SNOW-267971 Proper retries for LargeResultSetService #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-rsavenok merged 4 commits into from
Feb 4, 2026
Merged

SNOW-267971 Proper retries for LargeResultSetService #1249

sfc-gh-rsavenok merged 4 commits into from
Feb 4, 2026

Conversation

@sfc-gh-rsavenok
Copy link
Collaborator

@sfc-gh-rsavenok sfc-gh-rsavenok commented Jan 30, 2026 •
edited
Loading

Description

LargeResultSetService now retries any network error. But instead of using the new useSnowflakeRetryMiddleware, I fixed isRetryableClientError to meet all retry requirements.

Integration tests:

  • Coverage for LargeResultSetService
  • Improved connection timeout configuration for faster tests
  • Refactored test cases with testErrorScenarios helper for better readability and configurability

Checklist

  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-rsavenok sfc-gh-rsavenok requested a review from a team as a code owner January 30, 2026 19:31
@sfc-gh-rsavenok Graphite App
Copy link
Collaborator Author

sfc-gh-rsavenok commented Feb 2, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-rsavenok sfc-gh-rsavenok mentioned this pull request Feb 2, 2026
Merged
5 tasks
@sfc-gh-rsavenok sfc-gh-rsavenok force-pushed the rsavenok/SNOW-267971-retry-large-result-set branch from 0ee7292 to cbeaae0 Compare February 4, 2026 12:50
@sfc-gh-rsavenok sfc-gh-rsavenok merged commit e30bbaa into master Feb 4, 2026
63 of 69 checks passed
@sfc-gh-rsavenok sfc-gh-rsavenok deleted the rsavenok/SNOW-267971-retry-large-result-set branch February 4, 2026 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-rkowalski sfc-gh-rkowalski sfc-gh-rkowalski approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-snoonan sfc-gh-snoonan sfc-gh-snoonan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-rsavenok @sfc-gh-rkowalski @sfc-gh-pbulawa @sfc-gh-snoonan