Skip to content

Conversation

@sfc-gh-rsavenok
Copy link
Collaborator

Description

eval('require') prevents bundlers (esbuild, webpack, etc.) from statically analyzing and attempting to bundle .node native addon files

Checklist

  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-rsavenok sfc-gh-rsavenok requested a review from a team as a code owner February 5, 2026 11:51
@sfc-gh-rsavenok sfc-gh-rsavenok merged commit a40a1b8 into master Feb 5, 2026
63 of 69 checks passed
@sfc-gh-rsavenok sfc-gh-rsavenok deleted the rsavenok/fix-minicore-for-bundlers branch February 5, 2026 12:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants