Skip to content

SNOW-3031461 Do not send oauth scope when both role and oauthScope is empty #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-rsavenok merged 5 commits into from
Feb 9, 2026
Merged

SNOW-3031461 Do not send oauth scope when both role and oauthScope is empty #1262

sfc-gh-rsavenok merged 5 commits into from
Feb 9, 2026

Conversation

@sfc-gh-rsavenok
Copy link
Collaborator

@sfc-gh-rsavenok sfc-gh-rsavenok commented Feb 6, 2026 •
edited
Loading

Description

Currently, we send session:role:undefined. This results in Snowflake OAuth to throw an error:
image

The same skip logic is implemented in the Python driver. Even though Jenkins is red, its auth tests are passing.

Checklist

  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-rsavenok sfc-gh-rsavenok requested a review from a team as a code owner February 6, 2026 14:17
@sfc-gh-rsavenok sfc-gh-rsavenok mentioned this pull request Feb 6, 2026
Closed
5 tasks
sfc-gh-rkowalski
sfc-gh-rkowalski approved these changes Feb 9, 2026
View reviewed changes
Copy link

@sfc-gh-rkowalski sfc-gh-rkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sfc-gh-rsavenok sfc-gh-rsavenok merged commit 3f7e65d into master Feb 9, 2026
114 of 121 checks passed
@sfc-gh-rsavenok sfc-gh-rsavenok deleted the rsavenok/SNOW-3031461-fix-oauth-scope branch February 9, 2026 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-rkowalski sfc-gh-rkowalski sfc-gh-rkowalski approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-rsavenok @sfc-gh-rkowalski @sfc-gh-pbulawa