a runnable version without memleak and seg fault

Author: sfc-gh-aling

src/snowflake/connector/cpp/ArrowIterator/BinaryConverter.cpp

@@ -9,17 +9,17 @@ namespace sf
 {
 Logger* BinaryConverter::logger = new Logger("snowflake.connector.BinaryConverter");
 
-BinaryConverter::BinaryConverter(std::shared_ptr<ArrowArrayView> array)
+BinaryConverter::BinaryConverter(ArrowArrayView* array)
 : m_array(array)
 {
 }
 
 PyObject* BinaryConverter::toPyObject(int64_t rowIndex) const
 {
-  if(ArrowArrayViewIsNull(m_array.get(), rowIndex)) {
+  if(ArrowArrayViewIsNull(m_array, rowIndex)) {
     Py_RETURN_NONE;
   }
-  ArrowStringView stringView = ArrowArrayViewGetStringUnsafe(m_array.get(), rowIndex);
+  ArrowStringView stringView = ArrowArrayViewGetStringUnsafe(m_array, rowIndex);
     return PyByteArray_FromStringAndSize(stringView.data, stringView.size_bytes);
 }
 

src/snowflake/connector/cpp/ArrowIterator/BinaryConverter.hpp

@@ -16,12 +16,12 @@ namespace sf
 class BinaryConverter : public IColumnConverter
 {
 public:
-  explicit BinaryConverter(std::shared_ptr<ArrowArrayView> array);
+  explicit BinaryConverter(ArrowArrayView* array);
 
   PyObject* toPyObject(int64_t rowIndex) const override;
 
 private:
-  std::shared_ptr<ArrowArrayView> m_array;
+  ArrowArrayView* m_array;
 
   static Logger* logger;
 };

src/snowflake/connector/cpp/ArrowIterator/BooleanConverter.cpp

@@ -8,18 +8,18 @@
 namespace sf
 {
 
-BooleanConverter::BooleanConverter(std::shared_ptr<ArrowArrayView> array)
-: m_nanoarrowArrayView(array)
+BooleanConverter::BooleanConverter(ArrowArrayView* array)
+: m_array(array)
 {
 }
 
 PyObject* BooleanConverter::toPyObject(int64_t rowIndex) const
 {
-  if(ArrowArrayViewIsNull(m_nanoarrowArrayView.get(), rowIndex)) {
+  if(ArrowArrayViewIsNull(m_array, rowIndex)) {
     Py_RETURN_NONE;
   }
 
-  if(ArrowArrayViewGetIntUnsafe(m_nanoarrowArrayView.get(), rowIndex)) {
+  if(ArrowArrayViewGetIntUnsafe(m_array, rowIndex)) {
     Py_RETURN_TRUE;
   } else {
     Py_RETURN_FALSE;

src/snowflake/connector/cpp/ArrowIterator/BooleanConverter.hpp

@@ -15,12 +15,12 @@ namespace sf
 class BooleanConverter : public IColumnConverter
 {
 public:
-  explicit BooleanConverter(std::shared_ptr<ArrowArrayView> array);
+  explicit BooleanConverter(ArrowArrayView* array);
 
   PyObject* toPyObject(int64_t rowIndex) const override;
 
 private:
-  std::shared_ptr<ArrowArrayView> m_nanoarrowArrayView;
+  ArrowArrayView* m_array;
 };
 
 }  // namespace sf