Skip to content

SNOW-1903407: Changed not to use scoped temp stage #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-yixie merged 7 commits into from
Jan 30, 2025
Merged

SNOW-1903407: Changed not to use scoped temp stage #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b06c9e
Changed not to use scoped temp objects
sfc-gh-yixie Jan 30, 2025
651ffcf
Mark todo
sfc-gh-yixie Jan 30, 2025
06f68dd
Fix lint
sfc-gh-yixie Jan 30, 2025
8f5aae5
Bump version
sfc-gh-yixie Jan 30, 2025
f5d7289
Update requirements files
invalid-email-address Jan 30, 2025
d5b7e75
Use a variable to control the logic
sfc-gh-yixie Jan 30, 2025
977953f
Skip scoped objects test
sfc-gh-yixie Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions DESCRIPTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ https://docs.snowflake.com/
Source code is also available at: https://github.com/snowflakedb/snowflake-connector-python

# Release Notes
- v3.13.2(January 29, 2025)
- Changed not to use scoped temporary objects.

- v3.13.1(January 29, 2025)
- Remedied SQL injection vulnerability in snowflake.connector.pandas_tools.write_pandas. See more https://github.com/snowflakedb/snowflake-connector-python/security/advisories/GHSA-2vpq-fh52-j3wv
Expand Down
6 changes: 6 additions & 0 deletions src/snowflake/connector/pandas_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,12 @@ def write_pandas(
else False
)

"""sfc-gh-yixie: scoped temp stage isn't required out side of a SP.
TODO: remove the following line when merging SP connector and Python Connector.
Make sure `create scoped temp stage` is supported when it's not run in a SP.
"""
_use_scoped_temp_object = False

if create_temp_table:
warnings.warn(
"create_temp_table is deprecated, we still respect this parameter when it is True but "
Expand Down
2 changes: 1 addition & 1 deletion src/snowflake/connector/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Update this for the versions
# Don't change the forth version number from None
VERSION = (3, 13, 1, None)
VERSION = (3, 13, 2, None)
1 change: 1 addition & 0 deletions test/integ/pandas/test_pandas_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@ def mocked_execute(*args, **kwargs):
)


@pytest.mark.skip("scoped object isn't used yet.")
@pytest.mark.parametrize(
"database,schema,quote_identifiers,expected_db_schema",
[
Expand Down
2 changes: 1 addition & 1 deletion tested_requirements/requirements_310.reqs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ sortedcontainers==2.4.0
tomlkit==0.13.2
typing_extensions==4.12.2
urllib3==2.3.0
snowflake-connector-python==3.13.1
snowflake-connector-python==3.13.2
2 changes: 1 addition & 1 deletion tested_requirements/requirements_311.reqs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ sortedcontainers==2.4.0
tomlkit==0.13.2
typing_extensions==4.12.2
urllib3==2.3.0
snowflake-connector-python==3.13.1
snowflake-connector-python==3.13.2
2 changes: 1 addition & 1 deletion tested_requirements/requirements_312.reqs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ tomlkit==0.13.2
typing_extensions==4.12.2
urllib3==2.3.0
wheel==0.45.1
snowflake-connector-python==3.13.1
snowflake-connector-python==3.13.2
2 changes: 1 addition & 1 deletion tested_requirements/requirements_39.reqs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ sortedcontainers==2.4.0
tomlkit==0.13.2
typing_extensions==4.12.2
urllib3==1.26.20
snowflake-connector-python==3.13.1
snowflake-connector-python==3.13.2
Loading