SNOW-1944208 add unsafe write flag#2184
Merged
sfc-gh-mkubik merged 10 commits intomainfrom Feb 27, 2025
Merged
Conversation
Contributor
|
Wouldn't it be even more convenient (and transparent) to let users decide about exact permissions value to set? |
sfc-gh-mmishchenko
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
unsafe_file_writeflag to connection class. The security patch applied in 3.13.1 has narrowed the permissions of files downloaded with GET to 600. This change seems to be inconvenient for some customers that were relying on the previous behaviour in their workflows so after discussion with the support team we decided to add a flag that restores the previous behaviour of saving files downloaded with GET with 644.The parameter was added to all cloud interfaces, the default value is False which means the strict permissions will be applied.
The test had to be fixed since due to the compression on PUT the permissions weren't verified on the proper file.