fix error message when SF_AUTH_SOCKET_ADDR was set#2332
Merged
sfc-gh-mkubik merged 4 commits intosnowflakedb:mainfrom Jun 3, 2025
Merged
fix error message when SF_AUTH_SOCKET_ADDR was set#2332sfc-gh-mkubik merged 4 commits intosnowflakedb:mainfrom
sfc-gh-mkubik merged 4 commits intosnowflakedb:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
1 similar comment
Contributor
Author
|
recheck |
sfc-gh-pbulawa
approved these changes
May 22, 2025
sfc-gh-mkubik
approved these changes
May 22, 2025
Contributor
|
@rcleveng this change seems to have gotten the necessary approvals, thank you for your contribution again! |
Contributor
Author
|
@sfc-gh-dszmolka Sure, will do - the test failures so far look to be something environmental on the actions runner: I'm assuming they'll try again |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2116618: When SF_AUTH_SOCKET_ADDR is set, error message is incorrect, still mentions localhost #2331
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The error message for when a hostname does not resolve hardcodes localhost, and does not use SF_AUTH_SOCKET_ADDR when set. The change uses the value of SF_AUTH_SOCKET_ADDR if set
or localhost if not set in the error message.
(Optional) PR for stored-proc connector: