Skip to content

fix error message when SF_AUTH_SOCKET_ADDR was set#2332

Merged
sfc-gh-mkubik merged 4 commits intosnowflakedb:mainfrom
rcleveng:main
Jun 3, 2025
Merged

fix error message when SF_AUTH_SOCKET_ADDR was set#2332
sfc-gh-mkubik merged 4 commits intosnowflakedb:mainfrom
rcleveng:main

Conversation

@rcleveng
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2116618: When SF_AUTH_SOCKET_ADDR is set, error message is incorrect, still mentions localhost #2331

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    The error message for when a hostname does not resolve hardcodes localhost, and does not use SF_AUTH_SOCKET_ADDR when set. The change uses the value of SF_AUTH_SOCKET_ADDR if set
    or localhost if not set in the error message.

  4. (Optional) PR for stored-proc connector:

@github-actions
Copy link

github-actions bot commented May 22, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@rcleveng
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rcleveng
Copy link
Contributor Author

recheck

1 similar comment
@rcleveng
Copy link
Contributor Author

recheck

@sfc-gh-dszmolka
Copy link
Contributor

@rcleveng this change seems to have gotten the necessary approvals, thank you for your contribution again!
Can you please rebase to the latest main then merge after tests pass?

@rcleveng
Copy link
Contributor Author

@sfc-gh-dszmolka Sure, will do - the test failures so far look to be something environmental on the actions runner:

https://github.com/snowflakedb/snowflake-connector-python/actions/runs/15178991027/job/42780413977?pr=2332

0s
Run gpg --quiet --batch --yes --decrypt --passphrase="$PARAMETERS_SECRET" \
gpg: gcry_kdf_derive failed: Invalid data
gpg: decryption failed: Bad session key
Error: Process completed with exit code 2.

I'm assuming they'll try again

@sfc-gh-dszmolka sfc-gh-dszmolka added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 27, 2025
@sfc-gh-mkubik sfc-gh-mkubik mentioned this pull request Jun 3, 2025
@sfc-gh-mkubik sfc-gh-mkubik merged commit 07230cf into snowflakedb:main Jun 3, 2025
136 of 191 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-2116618: When SF_AUTH_SOCKET_ADDR is set, error message is incorrect, still mentions localhost

4 participants