Move unsafe_file_write parameter to DEFAULT_CONFIGURATION#2413
Merged
sfc-gh-pczajka merged 2 commits intomainfrom Jul 22, 2025
Merged
Conversation
sfc-gh-pczajka
added
NO-CHANGELOG-UPDATES
| if "host" not in kwargs: | ||
| self._host = construct_hostname(kwargs.get("region"), self._account) | ||
|
|
||
| if "unsafe_file_write" in kwargs: |
Contributor
There was a problem hiding this comment.
Can we add a quick test that by default our driver behaves in the way that unsafe_file_write = False describes.
Collaborator
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Great, then we are good 👍
I found the second test before, but I think we set there explicitly the value to True so it wasn't preventing changes in the default behaviour in the future.
Nevertheless, the first test You attached is what I needed indeed.
sfc-gh-fpawlowski
approved these changes
Jul 22, 2025
sfc-gh-pczajka
deleted the
SNOW-2207863-add-unsafe-file-write-to-default-parameters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2207863
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Move
unsafe_file_writeparameter to default configuration. Otherwise accessing this connection property before callingconnect()might've result in an error