SNOW-694457: env-vars-proxy-leaking #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-with-adapter
…pter' into SNOW-694457-env-vars-proxy-leaking # Conflicts: # test/integ/test_connection.py
…on-with-adapter
…on-with-adapter # Conflicts: # src/snowflake/connector/wif_util.py
…pter' into SNOW-694457-env-vars-proxy-leaking # Conflicts: # test/unit/test_connection.py
…on-with-adapter
…pter' into SNOW-694457-env-vars-proxy-leaking
…pter' into SNOW-694457-env-vars-proxy-leaking
…pter' into SNOW-694457-env-vars-proxy-leaking
sfc-gh-mmishchenko
approved these changes
Aug 12, 2025
…on-with-adapter
…pter' into SNOW-694457-env-vars-proxy-leaking
Base automatically changed from
SNOW-2203079-HTTP-traffic-without-interception-with-adapter
to
main
August 13, 2025 06:26
# Conflicts: # src/snowflake/connector/auth/_oauth_base.py # src/snowflake/connector/connection.py # src/snowflake/connector/result_batch.py # src/snowflake/connector/session_manager.py
sfc-gh-fpawlowski
added
the
DO_NOT_PORT_CHANGES_TO_SP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-694457
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Supports passing proxy setup as connection config - not only env vars.
Small changes in production code, big changes in tests - introduced mock proxy with wiremock.
(Optional) PR for stored-proc connector: