Skip to content

Cherrypicks to aio connector part9 #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: cherrypicks-to-aio-connector-part8
Choose a base branch
from
Open

Cherrypicks to aio connector part9 #2460

wants to merge 56 commits into from
+4,406 −1,402

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Aug 9, 2025 •
edited
Loading

sfc-gh-pmansour and others added 30 commits August 7, 2025 15:04
@sfc-gh-pmansour @sfc-gh-pczajka
Add support for workload identity federation (#2203)
2722b95
@sfc-gh-pczajka
[Async] Apply #2203 to async code
f1dd2bb
@sfc-gh-pczajka
use aiohttp in wif_util
c2cda00
@sfc-gh-pczajka
Remove duplication in wif_util
e776ae4
@sfc-gh-pczajka
remove duplication in workflow identity
a66b110
@sfc-gh-pczajka
properly mock tests
7ecd740
@sfc-gh-pczajka
use aioboto3
63f918c
@sfc-gh-pmansour @sfc-gh-pczajka
Replace return with raise in WIF error check (#2231)
78f08f6
@sfc-gh-pczajka
Fix inheritance order; add tests
c6394c7
@sfc-gh-pczajka
Fix async get_aws_region
30865dc
@sfc-gh-pczajka
remove silent exception catching; fix async get_aws_region
10b76d3
@sfc-gh-pczajka
review fix: add test cases
75470f9
@sfc-gh-pczajka
split csp_helpers into sync and async
a803c48
@sfc-gh-jszczerbinski @sfc-gh-pczajka
NO-SNOW: Run test when targeting branches other than main (#2221)
0d16928
@sfc-gh-aling @sfc-gh-pczajka
SNOW-2007887: improve error message handling related to timeout (#2236)
029197c
@sfc-gh-pczajka
[ASYNC] Apply #2236 to async code
53fcf4a
@sfc-gh-pbulawa @sfc-gh-pczajka
SNOW-1789751: Add GCP regional and virtual endpoints support (#2233)
80bfec9
@sfc-gh-pczajka
[ASYNC] Apply #2233 to async code
2a0f804
@sfc-gh-lspiegelberg @sfc-gh-pczajka
SNOW-2027116 Allow for UUID encoding in SnowflakeRestful interface (#…
92dda02 
…2254)
@sfc-gh-pczajka
[ASYNC] apply #2254 to async code
359b1c4
@sfc-gh-pbulawa @sfc-gh-pczajka
SNOW-1955965: Fix expired S3 credentials update (#2258)
bc6f1fb
@sfc-gh-pczajka
[ASYNC] apply #2258 to async code
d79fb54
@sfc-gh-mkubik @sfc-gh-pczajka
NO-SNOW Add PAT to authenticators allowing empty username, remove han…
e6c8cdd 
…dling of PAT in password field (#2264)
@sfc-gh-pczajka
[ASYNC] Apply #2264 to async code
bcc8735
@sfc-gh-mkubik @sfc-gh-pczajka
NO-SNOW Fix flaky query timeout test (#2266)
a61ee6b
@sfc-gh-akolodziejczyk @sfc-gh-pczajka
SNOW-2040000 change tag to bptp-stable (#2268)
9acde0c
@sfc-gh-mmishchenko @sfc-gh-pczajka
SNOW-2028051 introduce a new client_fetch_threads connection paramete…
ecd2134 
…r to decouple threads number limitations on fetching and pre-fetching (#2255)
@sfc-gh-pmansour @sfc-gh-pczajka
Add default entra app ID for Snowflake (#2267)
5f04572
@sfc-gh-pczajka
[ASYNC] update test after #2267
d42c572
@sfc-gh-fpawlowski @sfc-gh-pczajka
SNOW-2011595 Masking filter introduced on library levels (#2253)
adebadc
@sfc-gh-fpawlowski sfc-gh-fpawlowski force-pushed the cherrypicks-to-aio-connector-part9 branch from d2dba53 to d683f13 Compare August 9, 2025 09:12
@sfc-gh-fpawlowski sfc-gh-fpawlowski changed the base branch from cherrypicks-to-aio-connector-part7 to cherrypicks-to-aio-connector-part8 August 9, 2025 09:14
@sfc-gh-fpawlowski sfc-gh-fpawlowski force-pushed the cherrypicks-to-aio-connector-part9 branch from d683f13 to fba0ce8 Compare August 9, 2025 10:10
sfc-gh-fpawlowski and others added 18 commits August 9, 2025 14:12
@sfc-gh-fpawlowski
[Async] Apply #2198 to async code
8cb2f45
@sfc-gh-mkubik @sfc-gh-fpawlowski
SNOW-1989239 - prevent silent failures on nano-arrow conversion (#2227)
0a08f6b 
Co-authored-by: Adam Ling <[email protected]>

(cherry picked from commit 5e96035)
@sfc-gh-fpawlowski
[Async] Apply #2227 to async code
c9320ea
@sfc-gh-mkubik @sfc-gh-fpawlowski
NO-SNOW skip out of range year test on old driver (#2243)
0e44bfa 
(cherry picked from commit 2ab3745)
@sfc-gh-fpawlowski
[Async] Apply #2243 to async code
5254ff3
@sfc-gh-mkubik @sfc-gh-fpawlowski
SNOW-191538 remove copyright headers (#2238)
cd8f701 
(cherry picked from commit 813bbd8)
@sfc-gh-fpawlowski
[Async] Apply #2238 to async code
cb22ea9
@sfc-gh-pbulawa @sfc-gh-fpawlowski
SNOW-1789751: Pass GCS regional and virtual params (#2241)
e72912c 
(cherry picked from commit 985ec5e)
@sfc-gh-fpawlowski
[Async] Apply 2241 to async code
95cae93
@sfc-gh-zyao @sfc-gh-fpawlowski
SNOW-2019505 fix inconsistent force_put_overwrite value for _upload a… (
6ec0460 
#2247)

(cherry picked from commit e200620)
@sfc-gh-fpawlowski
[Async] Apply #2247 to async code
4893131
@sfc-gh-pbulawa @sfc-gh-fpawlowski
SNOW-1896089: Lower log level (#2251)
ff012ea 
(cherry picked from commit 44313a3)
@sfc-gh-fpawlowski
[Async] Apply #2251 to async code
56da1b9
@sfc-gh-jszczerbinski @sfc-gh-fpawlowski
SNOW-2026002: Invalid url became valid (#2252)
183c25d 
(cherry picked from commit 3a798e8)
@sfc-gh-lspiegelberg @sfc-gh-fpawlowski
SNOW-2011670 Allow url parameter requestId to be set with statement p…
d3654a6 
…arams (#2240)

As part of the Snowpark IR project, we will send AST as part of the request. To restore them faithfully on the server-side and avoid introducing yet another layer of indirection, we would like to use the HTTP Request Id. Currently, this Request Id is generated on the client as part of issuing the query. With this PR we introduce a new (client-side) statement parameter requestId that allows to overwrite the automatically generated request Id. requestId must be a valid UUID4 or UUID4 string.

(cherry picked from commit 6e214d0)
@sfc-gh-fpawlowski
[Async] Apply #2240 to async code
1668800
@sfc-gh-mkubik @sfc-gh-fpawlowski
NO-SNOW skip tests of custom requestId on olddriver (#2256)
592fd95 
(cherry picked from commit cc563d8)
@sfc-gh-fpawlowski
[Async] Apply #2256 to async code
68d64a4
@sfc-gh-fpawlowski sfc-gh-fpawlowski force-pushed the cherrypicks-to-aio-connector-part9 branch from fba0ce8 to 68d64a4 Compare August 9, 2025 12:14
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part8 branch from 609427f to 511d01e Compare August 11, 2025 10:50
sfc-gh-pczajka
sfc-gh-pczajka approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part8 branch 5 times, most recently from a513b10 to eb23308 Compare August 14, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.