Skip to content

Cherrypicks to aio connector part12 #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: cherrypicks-to-aio-connector-part11
Choose a base branch
from

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

@sfc-gh-pczajka sfc-gh-pczajka self-requested a review August 11, 2025 12:58
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change aio ot aio_it, or rather directories inside aio? Tests tend to have suffix _async anyway.
I think the second option is less chaotic, WDYT?
currently: test/integ/aio_it/lambda/some_test.py
proposition: test/integ/aio/lambda_it/some_test.py

@sfc-gh-pczajka sfc-gh-pczajka self-requested a review August 11, 2025 13:00
@sfc-gh-fpawlowski
Copy link
Contributor Author

Do we want to change aio ot aio_it, or rather directories inside aio? Tests tend to have suffix _async anyway. I think the second option is less chaotic, WDYT? currently: test/integ/aio_it/lambda/some_test.py proposition: test/integ/aio/lambda_it/some_test.py

I think we have to rethink well our markers here - do we want this automatic marking (defined in pytest_collection_modifyitems) to add both aio and integ/unit/... markers to our tests - or just the latter?

If both, we may actually need to rename both directories - I will look at this closer once we propagate changes that fix the tests - to observe how they are influenced by this change better.

@sfc-gh-fpawlowski sfc-gh-fpawlowski force-pushed the cherrypicks-to-aio-connector-part12 branch from 5146b17 to 3556643 Compare August 12, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants