Aio connector fix workflows #2475
Open
+1,268
−1,403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pczajka
added
NO-CHANGELOG-UPDATES
| def select_time_with_scale(conn_cnx, scale): | ||
| # Test key scales and meaningful cases in a single table operation | ||
| # Cover: no fractional seconds, milliseconds, microseconds, nanoseconds | ||
| scales = [0, 3, 6, 9] # Key precision levels |
There was a problem hiding this comment.
this seems not to be applied to async version
|
|
||
|
|
||
| @pytest.mark.skipolddriver | ||
| def test_put_md5(tmp_path, conn_cnx): | ||
| """This test uploads a single and a multi part file and makes sure that md5 is populated.""" | ||
| # Generate random files and folders | ||
| small_folder = tmp_path / "small" |
| def test_ocsp_cache_when_server_is_down( | ||
| mock_fetch_ocsp_response, tmpdir, random_ocsp_response_validation_cache | ||
| ): | ||
| def test_ocsp_cache_when_server_is_down(tmpdir): |
| @@ -303,7 +303,9 @@ class NotRetryableException(Exception): | |||
| def fake_request_exec(**kwargs): | |||
| headers = kwargs.get("headers") | |||
| cnt = headers["cnt"] | |||
| time.sleep(3) | |||
| time.sleep( | |||
There was a problem hiding this comment.
Timeout changes from this file are not applied to async code
There was a problem hiding this comment.
good catch!; fixed
| # Test that connection respects server default when not explicitly set | ||
| assert ( | ||
| cnx.client_session_keep_alive == server_default | ||
| ), f"Expected client_session_keep_alive={server_default} (server default), got {cnx.client_session_keep_alive}" |
There was a problem hiding this comment.
we can have those clear messages in async version as well
sfc-gh-pczajka
force-pushed
the
aio-connector-fix-workflows
branch
from
e673724 to
0dc54a6
Compare
sfc-gh-pczajka
force-pushed
the
aio-connector-fix-workflows
branch
from
149e337 to
322852d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks required to fix pipelines