Skip to content

SNOW-2161716: Fix config file permissions check and skip warning using env variable#2488

Merged
sfc-gh-gmerticariu merged 5 commits intomainfrom
SNOW-2161716-python-fix-permission-check-for-toml-config-file
Aug 21, 2025
Merged

SNOW-2161716: Fix config file permissions check and skip warning using env variable#2488
sfc-gh-gmerticariu merged 5 commits intomainfrom
SNOW-2161716-python-fix-permission-check-for-toml-config-file

Conversation

@sfc-gh-gmerticariu
Copy link
Contributor

@sfc-gh-gmerticariu sfc-gh-gmerticariu commented Aug 18, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-216171

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

The convention for the connections.toml file permissions is that if the file is writable by others, then an error should be raised. If the file is readable by others, a warning should be printed, with the possibility to skip the warning using an environment variable.

  1. (Optional) PR for stored-proc connector:

Copy link
Contributor

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but requires a BCR release.

@sfc-gh-gmerticariu sfc-gh-gmerticariu force-pushed the SNOW-2161716-python-fix-permission-check-for-toml-config-file branch from 484c99d to 73f73e6 Compare August 21, 2025 17:18
@sfc-gh-gmerticariu sfc-gh-gmerticariu requested a review from a team as a code owner August 21, 2025 17:18
@sfc-gh-gmerticariu sfc-gh-gmerticariu merged commit f27861f into main Aug 21, 2025
47 of 52 checks passed
@sfc-gh-gmerticariu sfc-gh-gmerticariu deleted the SNOW-2161716-python-fix-permission-check-for-toml-config-file branch August 21, 2025 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants