Support WIF Impersonation on GCP workloads#2496
Merged
sfc-gh-eqin merged 15 commits intomainfrom Sep 3, 2025
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
sfc-gh-pmansour
left a comment
There was a problem hiding this comment.
I think this is broadly the right direction! Let's clean up the code, validate it on a real GCP environment, add tests, then expand to other CSPs
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
61b6f2e to
ba7308c
Compare
e4cf2ed to
4c804ff
Compare
Base automatically changed from
pmansour/verify-users-in-wif-integration-test
to
main
August 29, 2025 07:37
Contributor
sfc-gh-pmansour
left a comment
There was a problem hiding this comment.
Looks great! Just rebase + fix a few minor comments, and I think you're ready to merge today :)
4c804ff to
ec794b4
Compare
sfc-gh-pmansour
approved these changes
Sep 2, 2025
ec794b4 to
c70fed8
Compare
Contributor
|
@sfc-gh-eqin you may need to update the release notes to add a new section for vNext, and add a bullet point saying impersonation for workload identity federation is now supported. |
sfc-gh-pmansour
approved these changes
Sep 3, 2025
Co-authored-by: Peter Mansour <peter.mansour@snowflake.com>
Co-authored-by: Peter Mansour <peter.mansour@snowflake.com>
sfc-gh-pczajka
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
SNOW-2183347
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
The issue is that some use cases have a CSP account that maps to multiple other CSP accounts, each of which may map to a Snowflake user.
The code does the following on GCP workloads:
workload_identity_impersonation_pathof impersonated accountsManual Testing
Verified that this works on GCP (see private doc)