Skip to content

SNOW-2161716: Raise error if the config file is writable by others#2501

Merged
sfc-gh-pczajka merged 4 commits intomainfrom
SNOW-2161716-python-write-permission-check-for-toml-config-file
Oct 1, 2025
Merged

SNOW-2161716: Raise error if the config file is writable by others#2501
sfc-gh-pczajka merged 4 commits intomainfrom
SNOW-2161716-python-write-permission-check-for-toml-config-file

Conversation

@sfc-gh-gmerticariu
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2161716. When the configurations.toml is writable by others we open ourselves to credentials tampering. This diff checks the write permissions of the file and raises and error in case the file is writable by group or others.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-gmerticariu sfc-gh-gmerticariu requested a review from a team as a code owner August 23, 2025 18:58
Copy link
Contributor

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll just keep it as for now without an approval to prevent a an accidental merging, since it's BCR and should be scheduled properly.

@sfc-gh-pczajka sfc-gh-pczajka enabled auto-merge (squash) October 1, 2025 13:15
@sfc-gh-pczajka sfc-gh-pczajka merged commit e3349a3 into main Oct 1, 2025
89 of 101 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the SNOW-2161716-python-write-permission-check-for-toml-config-file branch October 1, 2025 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants