[SNOW-2464063] bugfix: Fix string representation for year-month subtypes #2601
+76
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-2464063-year-month-foramt
branch
from
5388f75 to
6c6411d
Compare
sfc-gh-nkumar
force-pushed
the
nkumar-SNOW-2464063-year-month-foramt
branch
from
691a3e5 to
b8691f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2464063
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
We added INTERVAL YEAR TO MONTH type in Private preview for Interval data types. Now in Public preview (not released yet) we are adding two more types INTERVAL YEAR and INTERVAL MONTH. All of these 3 types are represented by same logical_type INTERVAL_YEAR_MONTH. And we use scale column Metadata field to represent the subtype in this case
scale = 0 -> interval year to month
scale = 1 -> interval year
scale = 2 -> interval month
We had this logic in connector to convert this interval year-month to string which only works correctly for interval year to month. This PR updates it to look at scale to fetch correct subtype and create string presentation accordingly.