NO-SNOW: Send telemetry when closing connection#2607
Merged
sfc-gh-turbaszek merged 4 commits intomainfrom Nov 4, 2025
Merged
Conversation
8833614 to
2be7bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code currently won't emit any telemetry:
on the other hand the following code works (sends telemetry)
The difference is that context manager handles connection closing differently than handler registered
atexit. The handler was configured to basically not send telemetry, causing potential loss of observability.However, the handler is already doing additional REST calls (in majority of cases):
snowflake-connector-python/src/snowflake/connector/connection.py
Line 1166 in 9c9be36
which under the hood does:
snowflake-connector-python/src/snowflake/connector/network.py
Lines 660 to 667 in 9c9be36
This PR proposes to adopt similar approach (send but not retry) in telemetry close handler.