SNOW-2194055: Separate server and redirect URIs in AuthHttpServer #2609
+271
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-turbaszek
force-pushed
the
turbaszek-SNOW-2194055-split-server-redirect-uris
branch
from
a57bbe5 to
00665af
Compare
sfc-gh-snoonan
requested changes
Oct 29, 2025
|
|
||
| def _read_uri_from_env(self) -> str: | ||
| oauth_socket_address = os.getenv( | ||
| ENV_VAR_OAUTH_SOCKET_ADDRESS, "http://localhost" |
There was a problem hiding this comment.
localhost, not http://localhost ?
Generally, this separation of host and port in this way rather than having the address specified as a hostport seems weird to me. Can you ensure the description explains why were are doing it this way?
| with AuthHttpServer(self._redirect_uri) as callback_server: | ||
| with AuthHttpServer( | ||
| redirect_uri=self._redirect_uri, | ||
| uri=self._read_uri_from_env(), |
There was a problem hiding this comment.
Do we intend to expose this only through this env variable? Or should customer be able to pass oauth_socket_address through connection params? Is it known at the start time of the application and should be only possible to override with this env var?
Anyway we may need to create a separate Jira ticket to update the docs to include this new parameter in OAuth documentation for Python Driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes support for
redirect_uri. Copy of #2400