Skip to content

Conversation

@sfc-gh-fpawlowski
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Oct 29, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review November 1, 2025 09:40
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner November 1, 2025 09:40
}
"message": null
},
"success": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change wasn't necessary for anything apart from purity of output - previous structure generated warnings because of this wrong placement of "success" section.

@sfc-gh-fpawlowski sfc-gh-fpawlowski added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Nov 3, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit ec14974 into main Nov 4, 2025
104 of 110 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the NO-SNOW-proxy-precence-fix branch November 4, 2025 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants