-
Notifications
You must be signed in to change notification settings - Fork 524
No snow proxy precence fix #2615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
92f80db
NO-SNOW: refactor for better extensibility in future
sfc-gh-fpawlowski efe9cfe
NO-SNOW: Added tests of proxy
sfc-gh-fpawlowski 918f8ae
NO-SNOW: One .clone to rule them all
sfc-gh-fpawlowski e2a50e9
NO-SNOW: Fix proxies test
sfc-gh-fpawlowski 4ab18fd
Merge branch 'main' into NO-SNOW-proxy-precence-fix
sfc-gh-fpawlowski e9f8ade
NO-SNOW: this how precedence should look like
sfc-gh-fpawlowski ab48660
NO-SNOW: Comments of weirds
sfc-gh-fpawlowski 9f1fc95
NO-SNOW: test for proxy precedence behaviour fixed
sfc-gh-fpawlowski 39cade5
NO-SNOW: removed comment - review fixes
sfc-gh-fpawlowski cdf5acf
Merge branch 'main' into NO-SNOW-proxy-precence-fix
sfc-gh-fpawlowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change wasn't necessary for anything apart from purity of output - previous structure generated warnings because of this wrong placement of "success" section.