Skip to content

NO-SNOW: added missing Jira ticket #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-fpawlowski merged 2 commits into from
Dec 8, 2025
Merged

NO-SNOW: added missing Jira ticket #2708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3149927
NO-SNOW: added missing Jira ticket
sfc-gh-fpawlowski Dec 7, 2025
08ba966
Merge branch 'main' into NO-SNOW-missing-jira-ticket
sfc-gh-fpawlowski Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/snowflake/connector/aio/_session_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ async def validate_ocsp(
ocsp_response_cache_uri=FEATURE_OCSP_RESPONSE_CACHE_FILE_NAME,
use_fail_open=self._snowflake_ocsp_mode == OCSPMode.FAIL_OPEN,
hostname=hostname,
# TODO: uncomment when issues with ocsp revoked certs in tests are fixed (reapply #2559)
# TODO (SNOW-2871292): uncomment when issues with ocsp revoked certs in tests are fixed (reapply #2559)
# root_certs_dict_lock_timeout=FEATURE_ROOT_CERTS_DICT_LOCK_TIMEOUT,
).validate(hostname, protocol, session_manager=session_manager)
if not v:
Expand Down
2 changes: 1 addition & 1 deletion test/integ/aio_it/test_connection_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,7 @@ async def test_ocsp_mode_insecure_mode_and_disable_ocsp_checks_mismatch_ocsp_ena
assert "snowflake.connector.aio._ocsp_snowflake" not in caplog.text


# TODO: uncomment when issues with ocsp revoked certs in tests are fixed (reapply #2559)
# TODO (SNOW-2871292): uncomment when issues with ocsp revoked certs in tests are fixed (reapply #2559)
# @pytest.mark.skipolddriver
# async def test_root_certs_dict_lock_timeout_fail_open(conn_cnx):
# """Test OCSP root certificates lock timeout with fail-open mode and side effect mock."""
Expand Down
Loading