Skip to content

Conversation

@sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2875436: Okta Auth #2691

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This is just a simple typo in the old code-base. Some unit testing should be added to verify that the function works.

  4. (Optional) PR for stored-proc connector:
    Stored-proc connector doesn't use Okta authentication!

@sfc-gh-mkeller sfc-gh-mkeller requested a review from a team as a code owner December 30, 2025 21:07
Copy link

@sfc-gh-merbel sfc-gh-merbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but as this error happened, we should have also:

  • unit test for this function
  • tests passing everywhere (currently we still have a red ones)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-2875436: Okta Auth

3 participants