SNOW-1619616: Update Readme with information on Locale and JUnit tests (#1867)#2267
Open
sfc-gh-wfateem wants to merge 3 commits intomasterfrom
Open
SNOW-1619616: Update Readme with information on Locale and JUnit tests (#1867)#2267sfc-gh-wfateem wants to merge 3 commits intomasterfrom
sfc-gh-wfateem wants to merge 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README.rst file to include locale configuration information for running tests. The change addresses potential test failures that can occur when locale settings are not properly configured.
- Adds documentation about locale settings that may cause test failures
- Provides a solution by instructing users to set LC_ALL=C environment variable
|
|
||
| .. code-block:: bash | ||
|
|
||
| export LC_ALL=C |
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to modify tests to make them locale agnostic instead?
Collaborator
Author
There was a problem hiding this comment.
@sfc-gh-rkowalski my opinion is that the two don't have to be mutually exclusive. You can update the documentation today, since it's already a problem, until the tests are reviewed and modified to be locale agnostic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.