SNOW-3010074 Fix incorrect closing of HTTP connections#2481
Open
sfc-gh-pfus wants to merge 1 commit intomasterfrom
Open
SNOW-3010074 Fix incorrect closing of HTTP connections#2481sfc-gh-pfus wants to merge 1 commit intomasterfrom
sfc-gh-pfus wants to merge 1 commit intomasterfrom
Conversation
00ef353 to
e12f32a
Compare
sfc-gh-snoonan
approved these changes
Feb 6, 2026
sfc-gh-snoonan
left a comment
There was a problem hiding this comment.
In theory this looks fine to me. Couple questions:
- Why keep the TTL argument at all? There's a constructor that doesn't require it.
- The intent of the TTL is to handle DNS re-resolution and to keep load balancing of different IPs on the backend well distributed. Today, these change infrequently enough that it shouldn't be a huge deal, and we don't publish a ton of IPs. However, I'm a bit worried this will eventually lead to hotspotting. Arguably, we get our load balancing across multiple clients rather than from the connection pool for one client though. So I will call it ok. I'd like to see a test around the DNS update behavior though.
sfc-gh-boler
reviewed
Feb 6, 2026
fd54a8b to
379695e
Compare
sfc-gh-dheyman
approved these changes
Feb 9, 2026
379695e to
692f2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-3010074 Fixes a couple of problems related to HTTP connections closing.
evictIdleConnectionsandevictExpiredConnections. This one creates a thread that actively monitors such connections. This thread is closed on either JVM shutdown (daemon) or when HTTP client is explicitly closed.setValidateAfterInactivityon a pool. With this setting, before retrieving a connection from a pool, the pool checks if the connection is still valid (i.e. it is not closed on the remote end).net.snowflake.jdbc.idle_connection_timeout(default 30s) that is used as a timeout in all three mentioned functions.