NO-SNOW: Add minicore initialization test#2503
Merged
sfc-gh-dheyman merged 4 commits intomasterfrom Feb 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a regression test to verify that DriverInitializer.initialize() correctly triggers Minicore.initializeAsync(). The test would have caught a bug where the async initialization call was accidentally dropped during API restructuring (commit a07520c). To support this test, the PR introduces Minicore.hasInitializationStarted() to check if initialization has begun, and DriverInitializer.resetForTesting() to enable proper test state cleanup.
Changes:
- Added test verifying DriverInitializer triggers Minicore initialization
- Added
Minicore.hasInitializationStarted()method to query initialization state - Added
DriverInitializer.resetForTesting()method for test isolation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/test/java/net/snowflake/client/internal/driver/DriverInitializerTest.java | New test class verifying DriverInitializer.initialize() triggers Minicore async initialization |
| src/main/java/net/snowflake/client/internal/driver/DriverInitializer.java | Added resetForTesting() method to reset initialization state for testing |
| src/main/java/net/snowflake/client/internal/core/minicore/Minicore.java | Added hasInitializationStarted() method to check if async initialization has been triggered |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/net/snowflake/client/internal/driver/DriverInitializer.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/internal/driver/DriverInitializer.java
Show resolved
Hide resolved
src/test/java/net/snowflake/client/internal/driver/DriverInitializerTest.java
Show resolved
Hide resolved
src/main/java/net/snowflake/client/internal/core/minicore/Minicore.java
Outdated
Show resolved
Hide resolved
…core.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…alizer.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sfc-gh-pfus
reviewed
Feb 16, 2026
src/test/java/net/snowflake/client/internal/driver/DriverInitializerTest.java
Show resolved
Hide resolved
sfc-gh-merbel
approved these changes
Feb 16, 2026
sfc-gh-pfus
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add test verifying that DriverInitializer.initialize() triggers minicore async initialization. This would have caught the regression fixed in a07520c, where the Minicore.initializeAsync() call was accidentally dropped during the public API restructuring. Also adds Minicore.isInitializationStarted() and DriverInitializer.resetForTesting() to support the test cleanly.
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.