NO-SNOW: Fix error swallowing in flaky testIssueSimpleDateFormat#2549
Open
sfc-gh-dheyman wants to merge 1 commit intomasterfrom
Open
NO-SNOW: Fix error swallowing in flaky testIssueSimpleDateFormat#2549sfc-gh-dheyman wants to merge 1 commit intomasterfrom
sfc-gh-dheyman wants to merge 1 commit intomasterfrom
Conversation
sfc-gh-merbel
approved these changes
Mar 11, 2026
sfc-gh-rkowalski
approved these changes
Mar 11, 2026
Collaborator
sfc-gh-rkowalski
left a comment
sfc-gh-rkowalski
left a comment
There was a problem hiding this comment.
This is for diagnosing the flakiness cause?
Collaborator
Author
Merge activity
|
sfc-gh-dheyman
force-pushed
the
03-11-no-snow_fix_error_swallowing_in_flaky_testissuesimpledateformat
branch
from
2be0a02 to
bfc7cb8
Compare
sfc-gh-merbel
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improved error handling in the multithreaded flatfile read integration test by adding proper exception propagation from worker threads to the main test thread. The
FlatfileReadclass now captures any exceptions that occur during execution in a volatileerrorfield, which is checked after thread completion. This ensures that test failures in worker threads are properly reported rather than being silently ignored. Additionally, removed unnecessary exception printing and cleaned up unused imports.