NO-SNOW: Fix StreamLoader vector metadata detection error handling#2551
Draft
sfc-gh-dheyman wants to merge 1 commit intomasterfrom
Draft
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| } catch (SQLException e) { | ||
| logger.error(e.getMessage(), e); | ||
| abort(new Loader.ConnectionError(Utils.getCause(e))); | ||
| logger.warn( |
Collaborator
There was a problem hiding this comment.
Aren't we allowing it to silently fail now since we don't throw exception?
sfc-gh-dheyman
force-pushed
the
03-12-no-snow_fix_streamloader_vector_metadata_detection_error_handling
branch
from
d03e605 to
253b404
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview