Skip to content

Commit ba474b8

Browse files
sfc-gh-joshisfc-gh-joshi
authored
NO-SNOW: Force sort in flaky pivot test (#4018)
1 parent 4706f25 commit ba474b8

File tree

4 files changed

+28
-28
lines changed

4 files changed

+28
-28
lines changed

‎src/snowflake/snowpark/dataframe_analytics_functions.py‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -276,15 +276,15 @@ def moving_agg(
276276
... window_sizes=[2, 3],
277277
... order_by=["ORDERDATE"],
278278
... group_by=["PRODUCTKEY"],
279-
... )
279+
... ).sort("ORDERDATE")
280280
>>> result.show()
281281
--------------------------------------------------------------------------------------------------------------------------------------
282282
|"ORDERDATE" |"PRODUCTKEY" |"SALESAMOUNT" |"SALESAMOUNT_SUM_2" |"SALESAMOUNT_AVG_2" |"SALESAMOUNT_SUM_3" |"SALESAMOUNT_AVG_3" |
283283
--------------------------------------------------------------------------------------------------------------------------------------
284-
|2023-01-04 |102 |250 |250 |250.000 |250 |250.000 |
285284
|2023-01-01 |101 |200 |200 |200.000 |200 |200.000 |
286285
|2023-01-02 |101 |100 |300 |150.000 |300 |150.000 |
287286
|2023-01-03 |101 |300 |400 |200.000 |600 |200.000 |
287+
|2023-01-04 |102 |250 |250 |250.000 |250 |250.000 |
288288
--------------------------------------------------------------------------------------------------------------------------------------
289289
<BLANKLINE>
290290
"""
@@ -390,14 +390,14 @@ def cumulative_agg(
390390
... group_by=["PRODUCTKEY"],
391391
... order_by=["ORDERDATE"],
392392
... is_forward=True
393-
... )
393+
... ).sort("ORDERDATE")
394394
>>> res.show()
395395
----------------------------------------------------------------------------------------------------------
396396
|"ORDERDATE" |"PRODUCTKEY" |"SALESAMOUNT" |"SALESAMOUNT_SUM" |"SALESAMOUNT_MIN" |"SALESAMOUNT_MAX" |
397397
----------------------------------------------------------------------------------------------------------
398-
|2023-01-03 |101 |300 |300 |300 |300 |
399-
|2023-01-02 |101 |100 |400 |100 |300 |
400398
|2023-01-01 |101 |200 |600 |100 |300 |
399+
|2023-01-02 |101 |100 |400 |100 |300 |
400+
|2023-01-03 |101 |300 |300 |300 |300 |
401401
|2023-01-04 |102 |250 |250 |250 |250 |
402402
----------------------------------------------------------------------------------------------------------
403403
<BLANKLINE>
@@ -582,15 +582,15 @@ def compute_lead(
582582
... leads=[1, 2],
583583
... order_by=["ORDERDATE"],
584584
... group_by=["PRODUCTKEY"]
585-
... )
585+
... ).sort("ORDERDATE")
586586
>>> res.show()
587587
--------------------------------------------------------------------------------------------
588588
|"ORDERDATE" |"PRODUCTKEY" |"SALESAMOUNT" |"SALESAMOUNT_LEAD_1" |"SALESAMOUNT_LEAD_2" |
589589
--------------------------------------------------------------------------------------------
590-
|2023-01-04 |102 |250 |NULL |NULL |
591590
|2023-01-01 |101 |200 |100 |300 |
592591
|2023-01-02 |101 |100 |300 |NULL |
593592
|2023-01-03 |101 |300 |NULL |NULL |
593+
|2023-01-04 |102 |250 |NULL |NULL |
594594
--------------------------------------------------------------------------------------------
595595
<BLANKLINE>
596596
"""
@@ -684,15 +684,15 @@ def time_series_agg(
684684
... windows=["1D", "-1D"],
685685
... sliding_interval="12H",
686686
... col_formatter=custom_formatter,
687-
... )
687+
... ).sort("ORDERDATE")
688688
>>> res.show()
689689
----------------------------------------------------------------------------------------------------------------------------------------------------
690690
|"PRODUCTKEY" |"SALESAMOUNT" |"ORDERDATE" |"SUM_SALESAMOUNT_1D" |"MAX_SALESAMOUNT_1D" |"SUM_SALESAMOUNT_-1D" |"MAX_SALESAMOUNT_-1D" |
691691
----------------------------------------------------------------------------------------------------------------------------------------------------
692-
|102 |250 |2023-01-04 00:00:00 |250 |250 |250 |250 |
693692
|101 |200 |2023-01-01 00:00:00 |300 |200 |200 |200 |
694693
|101 |100 |2023-01-02 00:00:00 |400 |300 |300 |200 |
695694
|101 |300 |2023-01-03 00:00:00 |300 |300 |400 |300 |
695+
|102 |250 |2023-01-04 00:00:00 |250 |250 |250 |250 |
696696
----------------------------------------------------------------------------------------------------------------------------------------------------
697697
<BLANKLINE>
698698
"""

‎src/snowflake/snowpark/functions.py‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8928,15 +8928,15 @@ def percent_rank(_emit_ast: bool = True) -> Column:
89288928
... ],
89298929
... schema=["x", "y", "z"]
89308930
... )
8931-
>>> df.select(percent_rank().over(Window.partition_by("x").order_by(col("y"))).alias("result")).show()
8931+
>>> df.select(percent_rank().over(Window.partition_by("x").order_by(col("y"), col("z"))).alias("result")).sort("result").show()
89328932
------------
89338933
|"RESULT" |
89348934
------------
89358935
|0.0 |
8936-
|0.5 |
8937-
|0.5 |
8938-
|0.0 |
89398936
|0.0 |
8937+
|0.5 |
8938+
|1.0 |
8939+
|1.0 |
89408940
------------
89418941
<BLANKLINE>
89428942
"""
@@ -8980,16 +8980,16 @@ def row_number(_emit_ast: bool = True) -> Column:
89808980
... ],
89818981
... schema=["x", "y", "z"]
89828982
... )
8983-
>>> df.select(row_number().over(Window.partition_by(col("X")).order_by(col("Y"))).alias("result")).show()
8984-
------------
8985-
|"RESULT" |
8986-
------------
8987-
|1 |
8988-
|2 |
8989-
|3 |
8990-
|1 |
8991-
|2 |
8992-
------------
8983+
>>> df.select(col("X"), row_number().over(Window.partition_by(col("X")).order_by(col("Y"))).alias("result")).sort("X", "result").show()
8984+
------------------
8985+
|"X" |"RESULT" |
8986+
------------------
8987+
|1 |1 |
8988+
|1 |2 |
8989+
|2 |1 |
8990+
|2 |2 |
8991+
|2 |3 |
8992+
------------------
89938993
<BLANKLINE>
89948994
"""
89958995
return _call_function("row_number", _emit_ast=_emit_ast)
@@ -9065,8 +9065,8 @@ def lead(
90659065
... ],
90669066
... schema=["x", "y", "z"]
90679067
... )
9068-
>>> df.select(lead("Z").over(Window.partition_by(col("X")).order_by(col("Y"))).alias("result")).collect()
9069-
[Row(RESULT=1), Row(RESULT=3), Row(RESULT=None), Row(RESULT=3), Row(RESULT=None)]
9068+
>>> df.select(lead("Z").over(Window.partition_by(col("X")).order_by(col("Y"))).alias("result")).sort("result").collect()
9069+
[Row(RESULT=None), Row(RESULT=None), Row(RESULT=1), Row(RESULT=3), Row(RESULT=3)]
90709070
"""
90719071
# AST.
90729072
ast = (
@@ -11501,7 +11501,7 @@ def bitmap_construct_agg(
1150111501
Example::
1150211502

1150311503
>>> df = session.create_dataframe([1, 32769], schema=["a"])
11504-
>>> df.select(bitmap_bucket_number(df["a"]).alias("bitmap_id"),bitmap_bit_position(df["a"]).alias("bit_position")).group_by("bitmap_id").agg(bitmap_construct_agg(col("bit_position")).alias("bitmap")).collect()
11504+
>>> df.select(bitmap_bucket_number(df["a"]).alias("bitmap_id"),bitmap_bit_position(df["a"]).alias("bit_position")).group_by("bitmap_id").agg(bitmap_construct_agg(col("bit_position")).alias("bitmap")).order_by("bitmap_id").collect()
1150511505
[Row(BITMAP_ID=1, BITMAP=bytearray(b'\\x00\\x01\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00')), Row(BITMAP_ID=2, BITMAP=bytearray(b'\\x00\\x01\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00'))]
1150611506
"""
1150711507
c = _to_col_if_str(relative_position, "bitmap_construct_agg")

‎src/snowflake/snowpark/session.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1794,7 +1794,7 @@ def replicate_local_environment(
17941794
17951795
Example::
17961796
1797-
>>> import sys, pytest; _ = (sys.version_info[:2] != (3, 9)) or pytest.skip()
1797+
>>> import sys, pytest; _ = (sys.version_info[:2] not in ((3, 9), (3, 12))) or pytest.skip()
17981798
>>> from snowflake.snowpark.functions import udf
17991799
>>> import numpy
18001800
>>> import pandas

‎tests/integ/scala/test_dataframe_aggregate_suite.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def test_pivot_snow_1869802_repro(session):
6363
Utils.check_answer(
6464
df.pivot(pivot_col="_2", values=["A", "B"]).function("min")("_3"),
6565
[Row(1, 10, 0), Row(2, 11, 12)],
66-
False,
66+
True,
6767
)
6868

6969

0 commit comments

Comments
 (0)