Skip to content

Commit c09a805

Browse files
Revert "SNOW-2268215: support group by all (#3889)" (#3935)
1 parent bca498b commit c09a805

File tree

10 files changed

+244
-437
lines changed

10 files changed

+244
-437
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#### New Features
88

99
- Added a new function `service` in `snowflake.snowpark.functions` that allows users to create a callable representing a Snowpark Container Services (SPCS) service.
10-
- Added a new function `group_by_all()` to the `DataFrame` class.
1110
- Added `connection_parameters` parameter to `DataFrameReader.dbapi()` (PuPr) method to allow passing keyword arguments to the `create_connection` callable.
1211
- Added support for `Session.begin_transaction`, `Session.commit` and `Session.rollback`.
1312
- Added support for the following functions in `functions.py`:

docs/source/snowpark/dataframe.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ DataFrame
5757
DataFrame.flatten
5858
DataFrame.groupBy
5959
DataFrame.group_by
60-
DataFrame.group_by_all
6160
DataFrame.group_by_grouping_sets
6261
DataFrame.intersect
6362
DataFrame.join

src/snowflake/snowpark/_internal/analyzer/analyzer.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@
9191
from snowflake.snowpark._internal.analyzer.grouping_set import (
9292
GroupingSet,
9393
GroupingSetsExpression,
94-
GroupByAll,
9594
)
9695
from snowflake.snowpark._internal.analyzer.select_statement import (
9796
Selectable,
@@ -347,8 +346,6 @@ def analyze(
347346
)
348347

349348
if isinstance(expr, GroupingSet):
350-
if isinstance(expr, GroupByAll):
351-
return "ALL"
352349
return self.grouping_extractor(expr, df_aliased_col_name_to_real_col_name)
353350

354351
if isinstance(expr, WindowExpression):

src/snowflake/snowpark/_internal/analyzer/grouping_set.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ class Rollup(GroupingSet):
4040
pass
4141

4242

43-
class GroupByAll(GroupingSet):
44-
pass
45-
46-
4743
class GroupingSetsExpression(Expression):
4844
def __init__(self, args: List[List[Expression]]) -> None:
4945
super().__init__()

0 commit comments

Comments
 (0)